You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/03/07 23:54:01 UTC
Review Request 44476: Revised comments about `link` semantics in
libprocess.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44476/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos
Description
-------
Revised comments about `link` semantics in libprocess.
Diffs
-----
3rdparty/libprocess/include/process/process.hpp c9ef4e86a4735c1c0342793b6d5144d80fc853a9
Diff: https://reviews.apache.org/r/44476/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 44476: Revised comments about `link` semantics in
libprocess.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44476/#review122427
-----------------------------------------------------------
Ship it!
- Vinod Kone
On March 8, 2016, 12:13 a.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44476/
> -----------------------------------------------------------
>
> (Updated March 8, 2016, 12:13 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Revised comments about `link` semantics in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp c9ef4e86a4735c1c0342793b6d5144d80fc853a9
>
> Diff: https://reviews.apache.org/r/44476/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 44476: Revised comments about `link` semantics in
libprocess.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44476/
-----------------------------------------------------------
(Updated March 8, 2016, 12:13 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Addressed code review comment.
Repository: mesos
Description
-------
Revised comments about `link` semantics in libprocess.
Diffs (updated)
-----
3rdparty/libprocess/include/process/process.hpp c9ef4e86a4735c1c0342793b6d5144d80fc853a9
Diff: https://reviews.apache.org/r/44476/diff/
Testing
-------
Thanks,
Neil Conway
Re: Review Request 44476: Revised comments about `link` semantics in
libprocess.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44476/#review122407
-----------------------------------------------------------
3rdparty/libprocess/include/process/process.hpp (lines 112 - 114)
<https://reviews.apache.org/r/44476/#comment184384>
How about
"For remote linked processes, this indicates that the TCP socket between the linker and linkee has failed (e.g., linkee process died, network error). ...."
?
- Vinod Kone
On March 7, 2016, 10:54 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44476/
> -----------------------------------------------------------
>
> (Updated March 7, 2016, 10:54 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Revised comments about `link` semantics in libprocess.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/process.hpp c9ef4e86a4735c1c0342793b6d5144d80fc853a9
>
> Diff: https://reviews.apache.org/r/44476/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Neil Conway
>
>