You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "unbridled-41 (via GitHub)" <gi...@apache.org> on 2026/10/09 21:03:18 UTC
[PR] fix(instance): attribute a cloud-import audit to the credential it read [rocketmq-dashboard]
unbridled-41 opened a new pull request, #5979:
URL: https://github.com/apache/rocketmq-dashboard/pull/5979
### Which Issue(s) This PR Fixes
Fixes #5978
### Problem / Evidence
`InstanceService.finishCloudImport` recorded `("IMPORT_CLOUD_INSTANCES", "INSTANCE", String.valueOf(credentialId), ...)`; the timeline drawer looks rows up by (resourceType, resourceName) (`MybatisPlusAuditRepository.applyFilters`, `ResourceOperationTimelineDrawer`), and `auditPresentation.ts` labels `INSTANCE` as "Instance". The credential service records its own operations as `CLOUD_CREDENTIAL` + the same id, and the per-instance `CREATE_INSTANCE` audits already cover the instances an import creates.
### Root cause / Fix
The resource identity held "a number about the import" instead of the entity it names. Record the credential.
### Priority and scoring
**PRIORITY 50** - impact 18/40 (false attribution plus a missing audit record for a privileged operation), blast radius 8/20, reproducibility 20/20 (pinned by the updated tests), maintenance value 4/20. **FIX_CONFIDENCE 90**.
### Tests
`cd server && mvn -o -B -ntp test -Dtest='InstanceServiceTest'` -> `Tests run: 98, Failures: 0, Errors: 0`. The two existing assertions that pinned the wrong tuple (`importCloudInstancesShouldAuditAFullyFailedImportAsFailedTest`, `importCloudInstancesShouldContinueAfterUnexpectedRegionFailureTest`) now require `CLOUD_CREDENTIAL` and fail before this change.
### Risk
Rows written before the change keep the old attribution; nothing else reads that tuple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(instance): attribute a cloud-import audit to the credential it read [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5979:
URL: https://github.com/apache/rocketmq-dashboard/pull/5979#issuecomment-6091395854
### Verification on the final commit (branch + commit + command results)
Every command from the description re-run on a fresh worktree of this branch (`git worktree add <dir> fork/<branch>`, no local modifications), at commit `08c6b9b066`:
| command | exit | result |
| --- | --- | --- |
| `cd server && mvn -o -B -ntp test -Dtest='InstanceServiceTest'` | 0 | `Tests run: 98, Failures: 0, Errors: 0, Skipped: 0 · BUILD SUCCESS` |
CI note: on this repository the `Backend Build` (binary-license-gate), `Frontend Build` / `Frontend Docker Build` (licence manifest) and `rmqctl Build` (YAML renderer quoting) jobs are red for every branch, trunk included; the module-level commands above are unaffected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(instance): attribute a cloud-import audit to the credential it read [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #5979: fix(instance): attribute a cloud-import audit to the credential it read
URL: https://github.com/apache/rocketmq-dashboard/pull/5979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(instance): attribute a cloud-import audit to the credential it read [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5979:
URL: https://github.com/apache/rocketmq-dashboard/pull/5979#issuecomment-6227219075
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(instance): attribute a cloud-import audit to the credential it read [rocketmq-dashboard]
Posted by "unbridled-41 (via GitHub)" <gi...@apache.org>.
unbridled-41 commented on PR #5979:
URL: https://github.com/apache/rocketmq-dashboard/pull/5979#issuecomment-6090237308
### CI status of this PR
`Backend Tests (Java 21)` — see the note below the list.
The four remaining red jobs are red for every branch, including `rocketmq-studio` itself:
- `Backend Build (Java 21)` — the `binary-license-gate` antrun step fails on a list of third-party jars (`spring-ai-*`, `swagger-ui`, `tencentcloud-sdk-*`, `zstd-jni`, ... : "missing complete upstream LICENSE/COPYING; a POM name or link is not a substitute"). This PR touches no build configuration; tracked by #5341.
- `Frontend Build (Node 20)` / `Frontend Docker Build` — the frontend licence manifest check fails the same way on branches that do not touch `web/` at all; tracked by #5346.
- `rmqctl Build (Go)` — `cmd` `TestMessageQueryCompletenessWarningTest` yaml subtests: `got {"items":[{"size":"3",...}]}, want {"size":3,...}`, i.e. the YAML renderer writes numbers as quoted strings where the test expects integer literals. Reproduced locally with `cd rmqctl && go test ./cmd/` from a checkout whose `rmqctl/` tree is byte-identical to `rocketmq-studio`'s, and owned by open PR #5850 ("keep yaml numbers unquoted").
`Backend Tests (Java 21)` failure attribution: `ResourceOwnershipGuardTest.migrationConcurrentStartupIsIdempotentTest` — `org.h2.jdbc.JdbcSQLNonTransientException: General error: java.util.ConcurrentModificationException` — the known flaky H2 concurrency test tracked by #5302. It reproduces independently of this diff (which touches no persistence code) and the same job passes on sibling PRs of the same batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org