You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Sian January (JIRA)" <ji...@apache.org> on 2006/11/30 15:24:21 UTC
[jira] Created: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
[classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
--------------------------------------------------------------------------------------
Key: HARMONY-2383
URL: http://issues.apache.org/jira/browse/HARMONY-2383
Project: Harmony
Issue Type: Improvement
Components: Classlib
Reporter: Sian January
Priority: Minor
Attachments: findbugspatch.txt
I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [classlib] [luni] HARMONY-2383: Fixes for some minor issues in the java.util package found by Melody
Posted by Nathan Beyer <nd...@apache.org>.
Not actively, no. I asked Sian to split up the patches, so they can be
reviewed independently, but I haven't gotten back to it since then, so
go for it.
On 12/18/06, Tim Ellison <t....@gmail.com> wrote:
> Nathan: are you looking at this JIRA? if not I'll grab it.
>
> Regards,
> Tim
>
> Sian January (JIRA) wrote:
> > [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> > --------------------------------------------------------------------------------------
> >
> > Key: HARMONY-2383
> > URL: http://issues.apache.org/jira/browse/HARMONY-2383
> > Project: Harmony
> > Issue Type: Improvement
> > Components: Classlib
> > Reporter: Sian January
> > Priority: Minor
> > Attachments: findbugspatch.txt
> >
> > I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
> >
>
[classlib] [luni] HARMONY-2383: Fixes for some minor issues in the
java.util package found by Melody
Posted by Tim Ellison <t....@gmail.com>.
Nathan: are you looking at this JIRA? if not I'll grab it.
Regards,
Tim
Sian January (JIRA) wrote:
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
>
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: java.util_patch.txt
Attached an updated patch containing all the fixes (but not the exclusion filters) (java.util_patch.txt) . To resolve this issue a comitter should review and apply exclusionFilter_patch.txt and also either review and apply java.util_patch.txt or review and apply all the individual patches, as listed below:
Formatter_Long_patch.txt
Formatter_OR_patch.txt
Formatter_toString_patch.txt
GregorianCalendar_patch.txt
HashMap_patch.txt
Hashtable_patch.txt
Properties_patch.txt
Scanner_patch.txt
Vector_patch.txt
WeakHashMap_patch.txt
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, java.util_patch.txt, Properties_patch.txt, Scanner_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: Scanner_patch.txt
Attached a patch for java.util.Scanner that removes a redundant null check. I missed this in my first pass, but noticed it again when I was creating the exclusion filters.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, Properties_patch.txt, Scanner_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=comments#action_12455570 ]
Sian January commented on HARMONY-2383:
---------------------------------------
No problem - I will attach individual patches. I think you're right about removing the transient keywords. At first glance it looked strange because there were transient fields in classes that were not serializable, but looking back at it it seems to be because some of the subtypes are serializable, so I will leave out those changes in my updated patches.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Nathan Beyer (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=comments#action_12455228 ]
Nathan Beyer commented on HARMONY-2383:
---------------------------------------
Can you split the patch into multiple patch files? These run across many different classes and fix many different things. I'd like to review each independently.
I do have one concern after initial review and that's the elimination of some of the 'transient' keywords. This could have a serious impact on the serialization of classes. Have you validated the serialization compatibility?
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Patch Info: [Patch Available]
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: exclusionFilter_patch.txt
Also attached a patch (exclusionFilter_patch.txt) for the FindBugs exclusion filter (standard/tools/FindBugs/exclusionFilter.xml) that excludes some false positives found in the java.util package.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, Properties_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: Formatter_toString_patch.txt
Formatter_OR_patch.txt
Formatter_Long_patch.txt
I have attached three patches for java.util.Formatter.
Formatter_toString_patch.txt changes calls to toString() on Strings to just use the String itself.
Formatter_OR_patch.txt changes some logic to use the short-circuit version of OR (|| instead of |).
Formatter_Long_patch.txt changes some integer multipliction to long multiplication in order to avoid an overflow.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=comments#action_12459633 ]
Sian January commented on HARMONY-2383:
---------------------------------------
Hi Tim - I think removing the transient keyword from AbstractList.modCount was a mistake. I thought I had changed that back as after Nathan's comment I realised that AbstractList does have Serializable subtypes. The other changes were applied as expected so I'm happy for the bug to be closed. Thanks!
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, java.util_patch.txt, Properties_patch.txt, Scanner_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: Properties_patch.txt
Attached a patch for java.util.Properties (Properties_patch.txt). Properties had a synchronized method (setProperty) that called another synchronized method (Hashtable.put()). It did not seem to be necessary to synchronize twice, and also fixes an inconsistency that Properties.setProperty was synchronized while Properties.getProperty was not.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, Properties_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: Hashtable_patch.txt
Attached a patch to java.util.Hashtable (Hashtable_patch.txt) that fixes inconsistent synchronization in the Hashtable class. Access to the contents of the Hashtable was not consistently synchronized when accessed by calling keySet(), entrySet() or values().
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=comments#action_12459542 ]
Alexey Varlamov commented on HARMONY-2383:
------------------------------------------
Is there any point in using "synchronized" construct rather than just keywrod? That is, instead of
public int size() {
- return elementCount;
+ synchronized (Hashtable.this) {
+ return elementCount;
}
write just
- public int size() {
+ public synchronized int size() {
return elementCount;
}
?
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, java.util_patch.txt, Properties_patch.txt, Scanner_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Issue Type: Bug (was: Improvement)
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: GregorianCalendar_patch.txt
I have attached a patch for java.util.GregorianCalendar (GregorianCalendar_patch.txt) that changes integer multiplication to long multiplication to avoid an overflow.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=comments#action_12459593 ]
Sian January commented on HARMONY-2383:
---------------------------------------
Alexey - doing "synchronized (Hashtable.this)" is locking the outer Hashtable object where as "public synchronized int size() { " is locking the anonymous inner object, which means that it doesn't block any other access that is synchronized on the Hashtable object. Hope that makes sense!
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, java.util_patch.txt, Properties_patch.txt, Scanner_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Tim Ellison resolved HARMONY-2383.
----------------------------------
Resolution: Fixed
Scanner null-check patch applied at repo revision r488661.
I disagree with removing the transient keyword from AbstractList#modCount, so that has not been applied.
Please check that the remainder have been applied as you expected.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, java.util_patch.txt, Properties_patch.txt, Scanner_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Tim Ellison reassigned HARMONY-2383:
------------------------------------
Assignee: Tim Ellison
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, java.util_patch.txt, Properties_patch.txt, Scanner_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: Vector_patch.txt
Attached a patch for java.util.Vector (Vector_patch.txt) that synchronizes an access to the elementCount field. Access to that field was synchronized everywhere else in the file except in that one place.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, Properties_patch.txt, Vector_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=comments#action_12455588 ]
Sian January commented on HARMONY-2383:
---------------------------------------
The patch has now been split into individual files. This means that all the attached patches are current except findbugspatch.txt.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, Properties_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=comments#action_12459620 ]
Tim Ellison commented on HARMONY-2383:
--------------------------------------
Sian,
Working with findbugspatch.txt, I applied patches apart from making the AbstractList#modCount field non-transient (I'm still staring at that one).
Remaining patches applied to LUNI module at repo revision r488656.
The exclusion list patch was applied at repo revision r488657.
Not finished yet...
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, java.util_patch.txt, Properties_patch.txt, Scanner_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: WeakHashMap_patch.txt
Attached a patch to java.util.WeakHashMap (WeakHashMap_patch.txt). The patch changes a transient field to non-transient. Since the class is not Serializable and has no Serializable subtypes in the class libraries it does not make sense for it to have a transient field.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, Properties_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: HashMap_patch.txt
Attached a patch for java.util.HashMap where an assignment made to a local variable that is never used has been changed to just call the method without assigning the result.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Tim Ellison closed HARMONY-2383.
--------------------------------
Verified by Sian.
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Sian January
> Assigned To: Tim Ellison
> Priority: Minor
> Attachments: exclusionFilter_patch.txt, findbugspatch.txt, Formatter_Long_patch.txt, Formatter_OR_patch.txt, Formatter_toString_patch.txt, GregorianCalendar_patch.txt, HashMap_patch.txt, Hashtable_patch.txt, java.util_patch.txt, Properties_patch.txt, Scanner_patch.txt, Vector_patch.txt, WeakHashMap_patch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-2383) [classlib] [luni] Fixes for some
minor issues in the java.util package found by Melody
Posted by "Sian January (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-2383?page=all ]
Sian January updated HARMONY-2383:
----------------------------------
Attachment: findbugspatch.txt
Patch attached
> [classlib] [luni] Fixes for some minor issues in the java.util package found by Melody
> --------------------------------------------------------------------------------------
>
> Key: HARMONY-2383
> URL: http://issues.apache.org/jira/browse/HARMONY-2383
> Project: Harmony
> Issue Type: Improvement
> Components: Classlib
> Reporter: Sian January
> Priority: Minor
> Attachments: findbugspatch.txt
>
>
> I have looked through the issues found by findbugs and have fixed all of the ones in the java.util package that seemed to be real issues.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira