[GitHub] [druid] jihoonson commented on a change in pull request #9590: DruidInputSource can add new dimensions during re-ingestion

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #9590: DruidInputSource can add new dimensions during re-ingestion
URL: https://github.com/apache/druid/pull/9590#discussion_r401914402
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/common/ReingestionTimelineUtils.java
 ##########
 @@ -101,4 +103,34 @@
                     .mapToObj(orderedMetrics::get)
                     .collect(Collectors.toList());
   }
+
+  /**
+   * Utility function to get dimensions that should be ingested. The preferred order is
+   * - Explicit dimensions if they are provided.
+   * - Custom dimensions are provided in the inputSpec.
+   * - Calculate dimensions from the timeline but exclude any dimension exclusions.
+   *
+   * @param explicitDimensions sent as part of the re-ingestion InputSource.
+   * @param dimensionsSpec from the provided ingestion spec.
+   * @param timeLineSegments for the datasource that is being read.
+   * @return
 
 Review comment:
   nit: please add description for the return value or remove this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org