You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by norbertpotocki <gi...@git.apache.org> on 2014/12/13 02:07:44 UTC
[GitHub] storm pull request: use generics when implementing TupleToKafkaMap...
GitHub user norbertpotocki opened a pull request:
https://github.com/apache/storm/pull/345
use generics when implementing TupleToKafkaMapper in FieldNameBasedTuple..
- use generics when implementing TupleToKafkaMapper in FieldNameBasedTupleToKafkaMapper
It fixes unchecked assignment warning in the following piece of code:
```java
public KafkaBolt kafkaBolt() {
return new KafkaBolt<String, String>()
.withTopicSelector(new DefaultTopicSelector(topicName))
.withTupleToKafkaMapper(new FieldNameBasedTupleToKafkaMapper<String, String>());
}
```
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/norbertpotocki/storm master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #345
----
commit 15d9c8e490916f2ac5570ad6cf323c9d7cb3d0c0
Author: Norbert Potocki <no...@nort.pl>
Date: 2014-12-13T00:57:20Z
use generics when implementing TupleToKafkaMapper in FieldNameBasedTupleToKafkaMapper
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use generics when implementing TupleToKafkaMap...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/345#issuecomment-66951604
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use generics when implementing TupleToKafkaMap...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/storm/pull/345#issuecomment-66866253
+1. I think this is small enough to not have a jira but I will let the committers decide.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: use generics when implementing TupleToKafkaMap...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/345
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---