[GitHub] Guadrado commented on a change in pull request #6510: Added support for filtering by unused parameter

[GitBox <gi...@apache.org>]

Guadrado commented on a change in pull request #6510: Added support for filtering by unused parameter
URL: https://github.com/apache/incubator-druid/pull/6510#discussion_r232598474
 
 

 ##########
 File path: indexing-service/src/main/java/org/apache/druid/indexing/overlord/MetadataTaskStorage.java
 ##########
 @@ -208,15 +208,15 @@ public void setStatus(final TaskStatus status)
   }
 
   @Override
-  public List<TaskInfo<Task, TaskStatus>> getRecentlyFinishedTaskInfo(
+  public List<TaskInfo<Task, TaskStatus>> getFinishedTaskInfoByCreatedTimeDuration(
       @Nullable Integer maxTaskStatuses,
-      @Nullable Duration duration,
+      @Nullable Duration createdTimeDuration,
 
 Review comment:
   I think, you're right and `durationBeforeNow` sounds better. Change method name to `getFinishedTaskInfoByCreatedTimeDuration` is enough to understand binding to `createdTime` parameter.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org