You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2008/06/26 05:40:45 UTC

[jira] Created: (HBASE-712) midKey found compacting is the first, not necessarily the optimal

midKey found compacting is the first, not necessarily the optimal
-----------------------------------------------------------------

                 Key: HBASE-712
                 URL: https://issues.apache.org/jira/browse/HBASE-712
             Project: Hadoop HBase
          Issue Type: Bug
            Reporter: stack
            Priority: Minor
             Fix For: 0.2.0


It does this in HRegion:

{code}
      for (HStore store: stores.values()) {
        final byte [] key = store.compact(force);                                                                                  
        if (key != null && midKey == null) {                                                                                       
          midKey = key;                                                                                                            
        }
      }
{code}

If many families, then we can return a suboptimal midKey.

Marking minor but including in 0.2 because (I think) the fix is trivial.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-712) midKey found compacting is the first, not necessarily the optimal

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman reassigned HBASE-712:
-----------------------------------

    Assignee: Jim Kellerman

> midKey found compacting is the first, not necessarily the optimal
> -----------------------------------------------------------------
>
>                 Key: HBASE-712
>                 URL: https://issues.apache.org/jira/browse/HBASE-712
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Jim Kellerman
>            Priority: Minor
>             Fix For: 0.2.0
>
>
> It does this in HRegion:
> {code}
>       for (HStore store: stores.values()) {
>         final byte [] key = store.compact(force);                                                                                  
>         if (key != null && midKey == null) {                                                                                       
>           midKey = key;                                                                                                            
>         }
>       }
> {code}
> If many families, then we can return a suboptimal midKey.
> Marking minor but including in 0.2 because (I think) the fix is trivial.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-712) midKey found compacting is the first, not necessarily the optimal

Posted by "Jim Kellerman (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jim Kellerman resolved HBASE-712.
---------------------------------

    Resolution: Fixed

Hstore now returns the size of the store along with the midKey so HRegion can decide which is the optimal mid key

> midKey found compacting is the first, not necessarily the optimal
> -----------------------------------------------------------------
>
>                 Key: HBASE-712
>                 URL: https://issues.apache.org/jira/browse/HBASE-712
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Jim Kellerman
>            Priority: Minor
>             Fix For: 0.2.0
>
>
> It does this in HRegion:
> {code}
>       for (HStore store: stores.values()) {
>         final byte [] key = store.compact(force);                                                                                  
>         if (key != null && midKey == null) {                                                                                       
>           midKey = key;                                                                                                            
>         }
>       }
> {code}
> If many families, then we can return a suboptimal midKey.
> Marking minor but including in 0.2 because (I think) the fix is trivial.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.