You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by ro...@apache.org on 2014/07/04 21:43:09 UTC

git commit: THRIFT-2594 JS Compiler: Single quotes are not being escaped in constants.

Repository: thrift
Updated Branches:
  refs/heads/master 0dd35a6c4 -> 45abf12f1


THRIFT-2594 JS Compiler: Single quotes are not being escaped in constants.

Patch: Thomas Lazar


Project: http://git-wip-us.apache.org/repos/asf/thrift/repo
Commit: http://git-wip-us.apache.org/repos/asf/thrift/commit/45abf12f
Tree: http://git-wip-us.apache.org/repos/asf/thrift/tree/45abf12f
Diff: http://git-wip-us.apache.org/repos/asf/thrift/diff/45abf12f

Branch: refs/heads/master
Commit: 45abf12f1353e982aea74ac9394438deb8a0a05e
Parents: 0dd35a6
Author: Roger Meier <ro...@apache.org>
Authored: Fri Jul 4 21:42:32 2014 +0200
Committer: Roger Meier <ro...@apache.org>
Committed: Fri Jul 4 21:42:32 2014 +0200

----------------------------------------------------------------------
 compiler/cpp/src/generate/t_js_generator.cc | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/thrift/blob/45abf12f/compiler/cpp/src/generate/t_js_generator.cc
----------------------------------------------------------------------
diff --git a/compiler/cpp/src/generate/t_js_generator.cc b/compiler/cpp/src/generate/t_js_generator.cc
index 7f53016..32cb162 100644
--- a/compiler/cpp/src/generate/t_js_generator.cc
+++ b/compiler/cpp/src/generate/t_js_generator.cc
@@ -74,6 +74,8 @@ class t_js_generator : public t_oop_generator {
      } else {
        out_dir_base_ = "gen-js";
      }
+
+     escape_['\''] = "\\'";
   }
 
   /**