[GitHub] [cordova-plugin-splashscreen] elitacco opened a new issue #191: Can not disable splash screen for browser platform

[GitBox <gi...@apache.org>]

elitacco opened a new issue #191: Can not disable splash screen for browser platform
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/191
 
 
   # Bug Report
   
   ## Problem
   
   ### What is expected to happen?
   Splash screen is disabled for browser platform using this configuration in config.xml:
   ```
   <platform name="browser">
       <preference name="ShowSplashScreen" value="false" />
   </platform>
   ```
   as explained in the documentation: [Browser quirks](https://cordova.apache.org/docs/en/latest/reference/cordova-plugin-splashscreen/#browser-quirks)
   
   ### What does actually happen?
   The splash screen is still showing
   
   ## Information
   <!-- Include all relevant information that might help understand and reproduce the problem -->
   I'm using "cordova-browser": "6.0.0"
   
   I think the problem is in : [SplashScreenProxy.js](https://github.com/apache/cordova-plugin-splashscreen/blob/8490496c0b5ecdb8798a3c3a4b93f0a3fe85c928/src/browser/SplashScreenProxy.js#L156)
   
   ```
   if (autoHideSplashScreen) {
               showAndHide();
           } else {
               SplashScreen.show();
           } 
   ```
   If autoHideSplashScreen is "false" (I have it set to "false" for all the platforms. But if I try to override it for browser platform it does not work either) then it will try to show the splash screen even if "ShowSplashScreen" is false.
   
   BTW. The documentation doesn't make any reference to the fact that config.xml is needed at yourdomain.com/config.xml in order for this plugin to work. I think it would be better to have and after_plugin_install hook that changes the values in SplashScreenProxy.js:
   ```
   var splashImageWidth = 170;
   var splashImageHeight = 200;
   var bgColor = "#464646";
   var imageSrc = '/img/logo.png';
   var splashScreenDelay = 3000; 
   var showSplashScreen = true; 
   ```
   
   ### Command or Code
   <!-- What command or code is needed to reproduce the problem? -->
   ionic cordova build browser 
   
   ### Environment, Platform, Device
   <!-- In what environment, on what platform or on which device are you experiencing the issue? -->
   Windows 10, Google Chrome browser Version 73.0.3683.103 (Official Build) (64-bit)
   
   ### Version information
   <!-- 
   What are relevant versions you are using?
   For example:
   Cordova: Cordova CLI, Cordova Platforms, Cordova Plugins 
   Other Frameworks: Ionic Framework and CLI version
   Operating System, Android Studio, Xcode etc.
   -->
   ```
   $ ionic info
   
   Ionic:
   
      ionic (Ionic CLI)             : 4.12.0 (C:\Users\Eliseo Castilla\AppData\Roaming\npm\node_modules\ionic)
      Ionic Framework               : @ionic/angular 4.2.0
      @angular-devkit/build-angular : 0.13.8
      @angular-devkit/schematics    : 7.3.8
      @angular/cli                  : 7.3.8
      @ionic/angular-toolkit        : 1.5.1
   
   Cordova:
   
      cordova (Cordova CLI) : 9.0.0 (cordova-lib@9.0.1)
      Cordova Platforms     : browser 6.0.0
      Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.4.1, (and 11 other plugins)
   
   System:
   
      Android SDK Tools : 26.1.1 (C:\Android\sdk)
      NodeJS            : v8.12.0 (C:\Program Files\nodejs\node.exe)
      npm               : 6.8.0
      OS                : Windows 10
   ```
   
   
   ## Checklist
   <!-- Please check the boxes by putting an x in the [ ] like so: [x] -->
   
   - [x] I searched for existing GitHub issues
   - [x] I updated all Cordova tooling to most recent version
   - [x] I included all the necessary information above
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org