You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by "Charles Reiss (Created) (JIRA)" <ji...@apache.org> on 2011/10/26 03:50:32 UTC
[jira] [Created] (MESOS-46) Refactor MasterTest to use fixture
Refactor MasterTest to use fixture
----------------------------------
Key: MESOS-46
URL: https://issues.apache.org/jira/browse/MESOS-46
Project: Mesos
Issue Type: Improvement
Components: test
Reporter: Charles Reiss
Assignee: Charles Reiss
Priority: Trivial
master_test.cpp contains a lot of redundant code Master/Slave/SchedulerDriver setup code that should be refactored into a test fixture.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-46) Refactor MasterTest to use fixture
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13207287#comment-13207287 ]
jiraposter@reviews.apache.org commented on MESOS-46:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2664/
-----------------------------------------------------------
(Updated 2012-02-13 22:31:04.818047)
Review request for mesos.
Changes
-------
Merged with trunk.
Summary (updated)
-------
This patch refactors MasterTest.* tests to use a test fixture, eliminating a bunch of redundant setup/teardown code. It also renames it to MasterSlaveTest to reflect that the current MasterTest actually tests both mesos::internal::master::Master and mesos::internal::slave::Slave together.
This addresses bug MESOS-46.
https://issues.apache.org/jira/browse/MESOS-46
Diffs (updated)
-----
src/tests/master_tests.cpp a411ba5
Diff: https://reviews.apache.org/r/2664/diff
Testing
-------
Thanks,
Charles
> Refactor MasterTest to use fixture
> ----------------------------------
>
> Key: MESOS-46
> URL: https://issues.apache.org/jira/browse/MESOS-46
> Project: Mesos
> Issue Type: Improvement
> Components: test
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Trivial
> Labels: patch
> Attachments: 0001-Refactor-MasterTests-to-use-fixture.patch
>
>
> master_test.cpp contains a lot of redundant code Master/Slave/SchedulerDriver setup code that should be refactored into a test fixture.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MESOS-46) Refactor MasterTest to use fixture
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-46?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141560#comment-13141560 ]
jiraposter@reviews.apache.org commented on MESOS-46:
----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2664/
-----------------------------------------------------------
Review request for mesos.
Summary
-------
This patch refactors MasterTest.* tests to use a test fixture, eliminating a bunch of redundant setup/teardown code. It also renames it to MasterSlaveTest to reflect that the current MasterTest actually tests both mesos::internal::master::Master and mesos::internal::slave::Slave together.
[This is just an import of the diff in the JIRA issue into reviewboard.]
This addresses bug MESOS-46.
https://issues.apache.org/jira/browse/MESOS-46
Diffs
-----
src/tests/master_tests.cpp 2438114
Diff: https://reviews.apache.org/r/2664/diff
Testing
-------
Thanks,
Charles
> Refactor MasterTest to use fixture
> ----------------------------------
>
> Key: MESOS-46
> URL: https://issues.apache.org/jira/browse/MESOS-46
> Project: Mesos
> Issue Type: Improvement
> Components: test
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Trivial
> Labels: patch
> Attachments: 0001-Refactor-MasterTests-to-use-fixture.patch
>
>
> master_test.cpp contains a lot of redundant code Master/Slave/SchedulerDriver setup code that should be refactored into a test fixture.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MESOS-46) Refactor MasterTest to use fixture
Posted by "Charles Reiss (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MESOS-46?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Reiss updated MESOS-46:
-------------------------------
Attachment: 0001-Refactor-MasterTests-to-use-fixture.patch
Patch attached; currently against github HEAD, which I hope will be the git mirror head by the time a reviewboard is set up.
> Refactor MasterTest to use fixture
> ----------------------------------
>
> Key: MESOS-46
> URL: https://issues.apache.org/jira/browse/MESOS-46
> Project: Mesos
> Issue Type: Improvement
> Components: test
> Reporter: Charles Reiss
> Assignee: Charles Reiss
> Priority: Trivial
> Labels: patch
> Attachments: 0001-Refactor-MasterTests-to-use-fixture.patch
>
>
> master_test.cpp contains a lot of redundant code Master/Slave/SchedulerDriver setup code that should be refactored into a test fixture.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira