[GitHub] [cordova-plugin-screen-orientation] breautek commented on pull request #79: ci: Upgrade build tools to use modern tooling & device profiles

[GitBox <gi...@apache.org>]

breautek commented on pull request #79:
URL: https://github.com/apache/cordova-plugin-screen-orientation/pull/79#issuecomment-787476530


   Test is failing on desktop browsers for this reason: https://github.com/apache/cordova-plugin-screen-orientation/issues/35#issuecomment-658536587
   
   Desktop browsers now implements the APIs, so we use them, but they will reject as you can't lock an orientation on desktop.
   
   On rejection, we will fallback to a cordova bridge, but we don't actually have a browser implementation for the fallback, thus resulting to `cordova.js:1001 Error: exec proxy not found for :: CDVOrientation :: screenOrientation` message.
   
   It sounds like these tests are going to have to be spied on to simulate, but we also should probably return a meaningful message when running in an environment that doesn't actually support orientation locking.
   
   I haven't tested yet, but I assume this works as intended in the mobile browser.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org