You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flume.apache.org by es...@apache.org on 2011/08/16 01:01:02 UTC
svn commit: r1158056 -
/incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java
Author: esammer
Date: Mon Aug 15 23:01:02 2011
New Revision: 1158056
URL: http://svn.apache.org/viewvc?rev=1158056&view=rev
Log:
- Added some notes about separation of function (i.e. start / stop) from state management (i.e. add / remove).
Modified:
incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java
Modified: incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java
URL: http://svn.apache.org/viewvc/incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java?rev=1158056&r1=1158055&r2=1158056&view=diff
==============================================================================
--- incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java (original)
+++ incubator/flume/branches/flume-728/flume-ng-node/src/main/java/org/apache/flume/node/nodemanager/DefaultLogicalNodeManager.java Mon Aug 15 23:01:02 2011
@@ -76,6 +76,10 @@ public class DefaultLogicalNodeManager e
@Override
public boolean add(LogicalNode node) {
+ /*
+ * FIXME: This type of overriding worries me. There should be a better
+ * separation of addition of nodes and management. (i.e. state vs. function)
+ */
Preconditions.checkState(getLifecycleState().equals(LifecycleState.START),
"You can not add nodes to a manager that hasn't been started");
@@ -91,6 +95,10 @@ public class DefaultLogicalNodeManager e
@Override
public boolean remove(LogicalNode node) {
+ /*
+ * FIXME: This type of overriding worries me. There should be a better
+ * separation of addition of nodes and management. (i.e. state vs. function)
+ */
Preconditions.checkState(getLifecycleState().equals(LifecycleState.START),
"You can not remove nodes from a manager that hasn't been started");