Re: [PR] feat: Remove charts from welcome page for users without access to edit charts [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #33946:
URL: https://github.com/apache/superset/pull/33946#issuecomment-4700109732

   Thanks for picking this back up @martimors, the feature itself makes sense. CI's red though, and I think it's the new tests: they call fetchMock.calls(...) but the existing ones use fetchMock.callHistory.calls(...). We're on fetch-mock v12 where the bare .calls() was dropped, so those three Without chart role tests should fail. Mind switching them to callHistory.calls and getting lint-frontend + sharded-jest green? Happy to take another look once it's passing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org