[jira] [Commented] (QUICKSTEP-124) Add a python script to auto fix CMakeLists files

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/QUICKSTEP-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457322#comment-16457322 ] 

ASF GitHub Bot commented on QUICKSTEP-124:
------------------------------------------

Github user zuyu commented on the issue:

    https://github.com/apache/incubator-quickstep/pull/346
  
    LGTM!


> Add a python script to auto fix CMakeLists files
> ------------------------------------------------
>
>                 Key: QUICKSTEP-124
>                 URL: https://issues.apache.org/jira/browse/QUICKSTEP-124
>             Project: Apache Quickstep
>          Issue Type: New Feature
>            Reporter: Jianqiao Zhu
>            Priority: Minor
>
> This PR adds a script that intends to help improve developer productivity by automatically fixing {{CMakeLists.txt}} files for the Quickstep project (with best effort).
> The script will do the following things:
>  * Scan the repo's subdirectories and collect {{#include}} information from all source code files.
>  * Parse existing {{CMakeLists.txt}} files and convert all "recognized" commands into proper intermediate representations – the "unrecognized" part will be kept as "verbal" lines.
>  * Resolve subdirectories, targets and link dependencies. Add / delete / update the corresponding entries.
>  * Convert the intermediate representations back to {{CMakeLists.txt}} files.
> *NOTE:* Currently the script is at its initial stage and will not update tests or conditional targets (i.e. those within cmake {{if}} commands). It is likely to work well if you just create/delete some files or add/remove some {{#include}}'s – otherwise additional manual fixes may need to be done after applying the script.
> *NOTE*: This is an auxiliary tool that is not part of Quickstep engine code.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)