You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/17 05:52:58 UTC

[GitHub] [spark] zhengruifeng commented on pull request #38253: [SPARK-40796][CONNECT][BUILD] Check the generated python protos in GitHub Actions

zhengruifeng commented on PR #38253:
URL: https://github.com/apache/spark/pull/38253#issuecomment-1280324428

   protos in existing master are out of sync, and are successfully detected by this PR:
   ```
   Start checking the generated codes in pyspark-connect.
   RUN: /__w/spark/spark/connector/connect/dev/generate_protos.sh /tmp/tmpme0gkjlx
   Different files: ['commands_pb2.py', 'commands_pb2.pyi']
   Generated files for pyspark-connect are out of sync! Please run ./connector/connect/dev/generate_protos.sh
   Error: Process completed with exit code 255.
   ```
   
   So I think it's ready


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org