You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "thisisnic (via GitHub)" <gi...@apache.org> on 2023/10/24 22:27:33 UTC
[PR] GH-37594: [R] Convenience function for returning schema code [arrow]
thisisnic opened a new pull request, #38445:
URL: https://github.com/apache/arrow/pull/38445
### Rationale for this change
Extracting the code from an existing schema is a fairly common task for folks who are new to arrow, but it requires interacting with R6 methods, which we typically try to abstract away from the user
### What changes are included in this PR?
Convenience wrapper function for calling the `code()` method on a schema object
### Are these changes tested?
Yup
### Are there any user-facing changes?
Yep
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37594: [R] Convenience function for returning schema code [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #38445:
URL: https://github.com/apache/arrow/pull/38445#issuecomment-1781464760
OK, not everything needs a convenience function, I'm closing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37594: [R] Convenience function for returning schema code [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #38445:
URL: https://github.com/apache/arrow/pull/38445#issuecomment-1778710542
Keen to think here about whether we want to merge this, or whether we want instead to better document the ways of working with schemas as if they're lists (i.e. how to assign, update, etc)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37594: [R] Convenience function for returning schema code [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic commented on PR #38445:
URL: https://github.com/apache/arrow/pull/38445#issuecomment-1778682692
There's also a philosophical discussion here as to whether we actually want to expose this functionality to end users so easily - we now have 2 different ways of working with schemas; as if they are lists, or via this method. The alternative to this PR is to do a better job of documenting ways of working with schemas (i.e. constructing, updating etc) and treat this feature as an "easter egg" and leave it as-is.
Keen to hear your thoughts here @jonkeane
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37594: [R] Convenience function for returning schema code [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38445:
URL: https://github.com/apache/arrow/pull/38445#issuecomment-1778143116
:warning: GitHub issue #37594 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37594: [R] Convenience function for returning schema code [arrow]
Posted by "jonkeane (via GitHub)" <gi...@apache.org>.
jonkeane commented on PR #38445:
URL: https://github.com/apache/arrow/pull/38445#issuecomment-1779276076
> Keen to think here about whether we want to merge this, or whether we want instead to better document the ways of working with schemas as if they're lists (i.e. how to assign values, update values, etc)?
These also aren't mutually exclusive. I'm +0 on if the helper function is _that much easier_ than the `$code()` to warrant the extra code + maintenance burden that could come from that, though I'm not opposed — just not a clear "oh yeah this is the thing!"
But docs about where either is useful is good — interacting programmatically versus copying and pasting a schema both have slightly different use cases IMHO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-37594: [R] Convenience function for returning schema code [arrow]
Posted by "thisisnic (via GitHub)" <gi...@apache.org>.
thisisnic closed pull request #38445: GH-37594: [R] Convenience function for returning schema code
URL: https://github.com/apache/arrow/pull/38445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org