You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by srdo <gi...@git.apache.org> on 2018/01/03 11:52:33 UTC
[GitHub] storm issue #2494: STORM-2880 Minor optimisation about kafka spout.
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2494
Bikeshedding incoming:
I'm not sure this is better. The two methods in ProcessingGuarantee are just named variants of equals. I think we might as well just replace the checks in KafkaSpout with == checks. I don't think e.g. `kafkaSpoutConfig.getProcessingGuarantee() == KafkaSpoutConfig.ProcessingGuarantee.AT_MOST_ONCE` is following the SRP any less than `kafkaSpoutConfig.getProcessingGuarantee().isAtMostOnceProcessing()` (the second one also violates the law of Demeter).
---