You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Chang Song (JIRA)" <ji...@apache.org> on 2010/11/08 08:54:09 UTC
[jira] Created: (ZOOKEEPER-920) L7 (application layer) ping support
L7 (application layer) ping support
-----------------------------------
Key: ZOOKEEPER-920
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
Project: Zookeeper
Issue Type: New Feature
Components: c client
Affects Versions: 3.3.1
Reporter: Chang Song
Priority: Minor
Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-920) L7 (application layer) ping
support
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930190#action_12930190 ]
Patrick Hunt commented on ZOOKEEPER-920:
----------------------------------------
bq. svn diff attached. Thank you very much.
No, thank you! :-) Regards.
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-920) L7 (application layer) ping
support
Posted by "Chang Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930389#action_12930389 ]
Chang Song commented on ZOOKEEPER-920:
--------------------------------------
Michi. Let me rephrase my question ;)
I was wondering if there is any standard way in unit testing Zookeeper C client library.
If not, can I simply write something in Python?
thank you.
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-920) L7 (application layer) ping support
Posted by "Chang Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chang Song updated ZOOKEEPER-920:
---------------------------------
Attachment: ZOOKEEPER-920.patch
svn diff attached.
Thank you very much.
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-920) L7 (application layer) ping
support
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930397#action_12930397 ]
Michi Mutsuzaki commented on ZOOKEEPER-920:
-------------------------------------------
I think it's better if you add a test to src/c/tests/TestClient.cc.
Thanks!
--Michi
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-920) L7 (application layer) ping
support
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930399#action_12930399 ]
Patrick Hunt commented on ZOOKEEPER-920:
----------------------------------------
In general unit tests for the c binding is an area we could use more help with (more tests). If you're interested. :-)
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-920) L7 (application layer) ping support
Posted by "Chang Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chang Song updated ZOOKEEPER-920:
---------------------------------
Attachment: (was: ZOOKEEPER-920.patch)
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-920) L7 (application layer) ping support
Posted by "Chang Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chang Song updated ZOOKEEPER-920:
---------------------------------
Attachment: ZOOKEEPER-920-1.patch
Added ZAPPPINGFAILED error for L7 ping error.
Fixed comments
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920-1.patch, ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-920) L7 (application layer) ping
support
Posted by "Michi Mutsuzaki (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12929974#action_12929974 ]
Michi Mutsuzaki commented on ZOOKEEPER-920:
-------------------------------------------
Hi Chang,
Thank you for the patch. Here are my comments:
- Could you document the return value of app_ping_fn? Something like "\return 0 on successful ping. non-zero on error" should be enough.
- Do you have a unit test for this?
- It might be better if send_ping returns something other than ZOPERATIONTIMEOUT in case of client ping failure. That way it's easier to tell whether it's client ping that failed.
Thanks!
Michi
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-920) L7 (application layer) ping support
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-920:
-----------------------------------
Fix Version/s: 3.4.0
Assignee: Chang Song
Hi Chang Song, you need to provide this as a patch file in order for us to consider, see this:
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute
basically do a "svn diff" at the toplevel and attach to this jira. Regards.
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-920) L7 (application layer) ping support
Posted by "Chang Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chang Song updated ZOOKEEPER-920:
---------------------------------
Attachment: (was: ZOOKEEPER-920-1.patch)
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-920) L7 (application layer) ping support
Posted by "Chang Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chang Song updated ZOOKEEPER-920:
---------------------------------
Attachment: ZOOKEEPER-920.patch
I have attached a new patch.
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-920) L7 (application layer) ping
support
Posted by "Chang Song (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12930007#action_12930007 ]
Chang Song commented on ZOOKEEPER-920:
--------------------------------------
Thank you very much for your feedback, Michi.
I was wondering how do you want the unit test for C client to be done?
> L7 (application layer) ping support
> -----------------------------------
>
> Key: ZOOKEEPER-920
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-920
> Project: Zookeeper
> Issue Type: New Feature
> Components: c client
> Affects Versions: 3.3.1
> Reporter: Chang Song
> Assignee: Chang Song
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-920-1.patch, ZOOKEEPER-920.patch
>
>
> Zookeeper is used in applications where fault tolerance is important. Its client i/o thread send/recv heartbeats to/fro Zookeeper ensemble to stay connected. However healthy heartbeat does not always means that the application that uses Zookeeper client is in good health, it only means that ZK client thread is in good health.
> This I needed something that can tagged onto Zookeeper ping that represents L7 (application) health as well.
> I have modified C client source to support this in minimal way. I am new to Zookeeper, so please code review this code. I am actually using this code in our in-house solution.
> https://github.com/tru64ufs/zookeeper/commit/2196d6d5114a2fd2c0a3bc9a55f4494d47d2aece
> Thank you very much.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.