You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2020/02/18 12:51:49 UTC
[GitHub] [incubator-iotdb] vesense opened a new pull request #822:
[IOTDB-502] NPE bug in `org.apache.iotdb.db.service.TSServiceImpl`
vesense opened a new pull request #822: [IOTDB-502] NPE bug in `org.apache.iotdb.db.service.TSServiceImpl`
URL: https://github.com/apache/incubator-iotdb/pull/822
The IoTDB server throws the following error when accessing 0.10 server(master) by 0.9 shell client (latest release).
Exception trace:
> org.apache.iotdb.db.service.TSServiceImpl#getTimeZone
> java.lang.NullPointerException: null at org.apache.iotdb.db.service.TSServiceImpl.getTimeZone(TSServiceImpl.java:1120) at org.apache.iotdb.service.rpc.thrift.TSIService$Processor$getTimeZone.getResult(TSIService.java:1853) at org.apache.iotdb.service.rpc.thrift.TSIService$Processor$getTimeZone.getResult(TSIService.java:1833) at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:38) at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:38) at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:313) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) at java.lang.Thread.run(Thread.java:748)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] vesense commented on issue #822: [IOTDB-502] Fix
possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
Posted by GitBox <gi...@apache.org>.
vesense commented on issue #822: [IOTDB-502] Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
URL: https://github.com/apache/incubator-iotdb/pull/822#issuecomment-587494625
@jixuan1989 You're right. I also found some other compatibility errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #822: [IOTDB-502]
Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on issue #822: [IOTDB-502] Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
URL: https://github.com/apache/incubator-iotdb/pull/822#issuecomment-588605411
> We should pay attention to the compatibility. Or it will cause troubles to users.
Hi, I will merge this PR now.
We can discuss how to handle the compatibility in a new discussion thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] vesense commented on issue #822: [IOTDB-502] Fix
possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
Posted by GitBox <gi...@apache.org>.
vesense commented on issue #822: [IOTDB-502] Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
URL: https://github.com/apache/incubator-iotdb/pull/822#issuecomment-587495697
We should pay attention to the compatibility. Otherwise, it will cause big trouble to users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #822: [IOTDB-502]
Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on issue #822: [IOTDB-502] Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
URL: https://github.com/apache/incubator-iotdb/pull/822#issuecomment-587491374
One more thing, we need to put "how to detect whether a client is compatible" on the agenda.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 commented on issue #822: [IOTDB-502]
Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
Posted by GitBox <gi...@apache.org>.
jixuan1989 commented on issue #822: [IOTDB-502] Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
URL: https://github.com/apache/incubator-iotdb/pull/822#issuecomment-587490819
I tried. In this way, the start-client.sh tool will report:
```
IoTDB> Can not establish connection with jdbc:iotdb://127.0.0.1:6667/. Host is 127.0.0.1, port is 6667.
```
If we use JDCB like
```
Connection connection = DriverManager.getConnection("jdbc:iotdb://127.0.0.1:6667/", "root", "root")
```
then an exception will be thrown:
```
Exception in thread "main" java.sql.SQLException: Can not establish connection with jdbc:iotdb://127.0.0.1:6667/.
at org.apache.iotdb.jdbc.IoTDBConnection.openSession(IoTDBConnection.java:435)
at org.apache.iotdb.jdbc.IoTDBConnection.<init>(IoTDBConnection.java:84)
at org.apache.iotdb.jdbc.IoTDBDriver.connect(IoTDBDriver.java:63)
at java.sql.DriverManager.getConnection(DriverManager.java:664)
at java.sql.DriverManager.getConnection(DriverManager.java:247)
at org.apache.iotdb.JDBCExample.main(JDBCExample.java:32)
Caused by: org.apache.thrift.TApplicationException: getTimeZone failed: unknown result
at org.apache.iotdb.service.rpc.thrift.TSIService$Client.recv_getTimeZone(TSIService.java:405)
at org.apache.iotdb.service.rpc.thrift.TSIService$Client.getTimeZone(TSIService.java:389)
at org.apache.iotdb.jdbc.IoTDBConnection.getTimeZone(IoTDBConnection.java:475)
at org.apache.iotdb.jdbc.IoTDBConnection.openSession(IoTDBConnection.java:431)
... 5 more
```
It is accepted, at least better than the current status.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] vesense edited a comment on issue #822:
[IOTDB-502] Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
Posted by GitBox <gi...@apache.org>.
vesense edited a comment on issue #822: [IOTDB-502] Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
URL: https://github.com/apache/incubator-iotdb/pull/822#issuecomment-587495697
We should pay attention to the compatibility. Or it will cause troubles to users.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-iotdb] jixuan1989 merged pull request #822: [IOTDB-502]
Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
Posted by GitBox <gi...@apache.org>.
jixuan1989 merged pull request #822: [IOTDB-502] Fix possible NPE in `org.apache.iotdb.db.service.TSServiceImpl`
URL: https://github.com/apache/incubator-iotdb/pull/822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services