You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by "Rajeshbabu Chintaguntla (JIRA)" <ji...@apache.org> on 2016/05/24 16:30:13 UTC

[jira] [Comment Edited] (PHOENIX-2903) Handle split during scan for row key ordered aggregations

    [ https://issues.apache.org/jira/browse/PHOENIX-2903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15298461#comment-15298461 ] 

Rajeshbabu Chintaguntla edited comment on PHOENIX-2903 at 5/24/16 4:30 PM:
---------------------------------------------------------------------------

In ScanUtil#setLocalIndexAttributes we need to replace SCAN_ACTUAL_START_ROW with SCAN_START_ROW to set region start key as actual start key. 
{noformat}
    public static void setLocalIndexAttributes(Scan newScan, int keyOffset, byte[] regionStartKey, byte[] regionEndKey, byte[] startRowSuffix, byte[] stopRowSuffix) {
         if(ScanUtil.isLocalIndex(newScan)) {
-             newScan.setAttribute(SCAN_ACTUAL_START_ROW, regionStartKey);

{noformat}


was (Author: rajeshbabu):
bq. In ScanUtil#setLocalIndexAttributes we need to replace SCAN_ACTUAL_START_ROW with SCAN_START_ROW to set region start key as actual start key. 
{noformat}
    public static void setLocalIndexAttributes(Scan newScan, int keyOffset, byte[] regionStartKey, byte[] regionEndKey, byte[] startRowSuffix, byte[] stopRowSuffix) {
         if(ScanUtil.isLocalIndex(newScan)) {
-             newScan.setAttribute(SCAN_ACTUAL_START_ROW, regionStartKey);

{noformat}

> Handle split during scan for row key ordered aggregations
> ---------------------------------------------------------
>
>                 Key: PHOENIX-2903
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2903
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: James Taylor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-2903_v1.patch, PHOENIX-2903_v2.patch, PHOENIX-2903_v3.patch, PHOENIX-2903_wip.patch
>
>
> Currently a hole in our split detection code



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)