[GitHub] vanzin commented on a change in pull request #23686: [SPARK-26772][YARN] Delete ServiceCredentialProvider and make HadoopDelegationTokenProvider a developer API

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #23686: [SPARK-26772][YARN] Delete ServiceCredentialProvider and make HadoopDelegationTokenProvider a developer API
URL: https://github.com/apache/spark/pull/23686#discussion_r256919295
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/security/HadoopDelegationTokenProvider.scala
 ##########
 @@ -18,15 +18,17 @@
 package org.apache.spark.deploy.security
 
 Review comment:
   I remembered that things under `org.apache.spark.deploy` are not really "public" in Spark's view (i.e. they're not publicly documented). So leaving this interface here would mean it still remains in an awkward situation.
   
   We should probably move the interface to `org.apache.spark.security` (the rest could stay here). Up to you if you want to do it here or in a separate patch.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org