You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2020/04/14 15:35:53 UTC
[Impala-ASF-CR] IMPALA-9071: remove xfail from ACID CTAS test
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15729
Change subject: IMPALA-9071: remove xfail from ACID CTAS test
......................................................................
IMPALA-9071: remove xfail from ACID CTAS test
The test passes at the moment - according to the TODO
it needed HIVE-22158, which is included in CDP dependencies
since a long time.
Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
---
M tests/custom_cluster/test_custom_hive_configs.py
1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/29/15729/1
--
To view, visit http://gerrit.cloudera.org:8080/15729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
Gerrit-Change-Number: 15729
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-9071: remove xfail from ACID CTAS test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15729 )
Change subject: IMPALA-9071: remove xfail from ACID CTAS test
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5801/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
Gerrit-Change-Number: 15729
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 16:16:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9071: remove xfail from ACID CTAS test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15729 )
Change subject: IMPALA-9071: remove xfail from ACID CTAS test
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5649/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/15729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
Gerrit-Change-Number: 15729
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 15:42:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9071: remove xfail from ACID CTAS test
Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/15729 )
Change subject: IMPALA-9071: remove xfail from ACID CTAS test
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
Gerrit-Change-Number: 15729
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 15:38:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9071: remove xfail from ACID CTAS test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15729 )
Change subject: IMPALA-9071: remove xfail from ACID CTAS test
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
Gerrit-Change-Number: 15729
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 20:07:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9071: remove xfail from ACID CTAS test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15729 )
Change subject: IMPALA-9071: remove xfail from ACID CTAS test
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
Gerrit-Change-Number: 15729
Gerrit-PatchSet: 2
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 15:42:55 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-9071: remove xfail from ACID CTAS test
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15729 )
Change subject: IMPALA-9071: remove xfail from ACID CTAS test
......................................................................
IMPALA-9071: remove xfail from ACID CTAS test
The test passes at the moment - according to the TODO
it needed HIVE-22158, which is included in CDP dependencies
since a long time.
Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
Reviewed-on: http://gerrit.cloudera.org:8080/15729
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/custom_cluster/test_custom_hive_configs.py
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/15729
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e068879100061bb7e724f0bd1e5e4aa8edd7825
Gerrit-Change-Number: 15729
Gerrit-PatchSet: 3
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>