You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/14 11:28:23 UTC
[GitHub] [doris] morrySnow opened a new pull request, #13382: [feature](Nereids) generate ExprId from 0 for each statement
morrySnow opened a new pull request, #13382:
URL: https://github.com/apache/doris/pull/13382
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #13382: [feature](Nereids) generate ExprId from 0 for each statement
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #13382:
URL: https://github.com/apache/doris/pull/13382#discussion_r996621918
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/LogicalPlanAdapter.java:
##########
@@ -85,6 +92,6 @@ public String toDigest() {
}
public static LogicalPlanAdapter of(Plan plan) {
- return new LogicalPlanAdapter((LogicalPlan) plan);
+ return new LogicalPlanAdapter((LogicalPlan) plan, null);
Review Comment:
u r right, UT and regression test not be processed now
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/LogicalPlanAdapter.java:
##########
@@ -62,21 +65,25 @@ public OutFileClause getOutFileClause() {
return null;
}
+ public void setResultExprs(List<Expr> resultExprs) {
+ this.resultExprs = resultExprs;
+ }
+
@Override
public List<Expr> getResultExprs() {
return resultExprs;
}
- public ArrayList<String> getColLabels() {
- return colLabels;
+ public void setColLabels(ArrayList<String> colLabels) {
+ this.colLabels = colLabels;
}
- public void setResultExprs(List<Expr> resultExprs) {
- this.resultExprs = resultExprs;
+ public ArrayList<String> getColLabels() {
Review Comment:
ok~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13382: [feature](Nereids) generate ExprId from 0 for each statement
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13382:
URL: https://github.com/apache/doris/pull/13382#issuecomment-1281705993
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 38.75 seconds
load time: 583 seconds
storage size: 17154562352 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221018095243_clickbench_pr_30408.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow merged pull request #13382: [feature](Nereids) generate ExprId from 0 for each statement
Posted by GitBox <gi...@apache.org>.
morrySnow merged PR #13382:
URL: https://github.com/apache/doris/pull/13382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] englefly commented on a diff in pull request #13382: [feature](Nereids) generate ExprId from 0 for each statement
Posted by GitBox <gi...@apache.org>.
englefly commented on code in PR #13382:
URL: https://github.com/apache/doris/pull/13382#discussion_r995878371
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/LogicalPlanAdapter.java:
##########
@@ -62,21 +65,25 @@ public OutFileClause getOutFileClause() {
return null;
}
+ public void setResultExprs(List<Expr> resultExprs) {
+ this.resultExprs = resultExprs;
+ }
+
@Override
public List<Expr> getResultExprs() {
return resultExprs;
}
- public ArrayList<String> getColLabels() {
- return colLabels;
+ public void setColLabels(ArrayList<String> colLabels) {
+ this.colLabels = colLabels;
}
- public void setResultExprs(List<Expr> resultExprs) {
- this.resultExprs = resultExprs;
+ public ArrayList<String> getColLabels() {
Review Comment:
it would be better to keep the origin order of getColLabels and setResultExprs in order to reduce effort of merge code.
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/LogicalPlanAdapter.java:
##########
@@ -85,6 +92,6 @@ public String toDigest() {
}
public static LogicalPlanAdapter of(Plan plan) {
- return new LogicalPlanAdapter((LogicalPlan) plan);
+ return new LogicalPlanAdapter((LogicalPlan) plan, null);
Review Comment:
does it introduce NPE? how about remove this function, or add StatementContext parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #13382: [feature](Nereids) generate ExprId from 0 for each statement
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #13382:
URL: https://github.com/apache/doris/pull/13382#issuecomment-1279402233
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221015035609_clickbench_pr_29551.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org