You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/15 10:43:05 UTC
[GitHub] [maven-release] pzygielo opened a new pull request #55: Remove unused branch and initialize workDirectory immediately
pzygielo opened a new pull request #55:
URL: https://github.com/apache/maven-release/pull/55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] asfgit closed pull request #55: Remove unused branch and initialize workDirectory immediately
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #55:
URL: https://github.com/apache/maven-release/pull/55
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] pzygielo commented on pull request #55: Remove unused branch and initialize workDirectory immediately
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #55:
URL: https://github.com/apache/maven-release/pull/55#issuecomment-633131675
This might be called with `simulate == true`, but in such case we return in line 94. After that simulate can only be `false`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] pzygielo commented on pull request #55: Remove unused branch and initialize workDirectory immediately
Posted by GitBox <gi...@apache.org>.
pzygielo commented on pull request #55:
URL: https://github.com/apache/maven-release/pull/55#issuecomment-631255498
> What is the motivation behind this change?
To improve code quality.
> What is wrong with the current behavior?
Nothing, behaviour is not changed with this patch.
It clears violation of [RSPEC-2583](https://rules.sonarsource.com/java/type/Bug/RSPEC-2583) however.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #55: Remove unused branch and initialize workDirectory immediately
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #55:
URL: https://github.com/apache/maven-release/pull/55#issuecomment-633133014
>
>
> This might be called with `simulate == true`, but in such case we return in line 94. After that simulate can only be `false`.
Completely missed that. Then your change makes sense of course. Let me run all tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org