You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by "iuliana (via GitHub)" <gi...@apache.org> on 2024/07/17 09:23:55 UTC
[PR] Upgraded Go version an Go dependencies versions [brooklyn-client]
iuliana opened a new pull request, #104:
URL: https://github.com/apache/brooklyn-client/pull/104
**What**
----
Upgraded Golang version used to build this project 1.20 -> 1.22.5.
Upgraded the following dependencies:
1. `github.com/urfave/cli/v2`: v2.25.0 -> v2.27.2
2. `golang.org/x/crypto`: v0.7.0 -> v0.25.0
3. `k8s.io/client-go`: v0.26.2 -> v0.30.2
4. `github.com/cpuguy83/go-md2man/v2`: v2.0.2 -> v2.0.4
5. `github.com/xrash/smetrics`: v0.0.0-20201216005158-039620a65673 -> v0.0.0-20240312152122-5f08fbb34913
6. `golang.org/x/sys`: v0.6.0 -> v0.22.0
7. `golang.org/x/term`: v0.6.0 -> v0.22.0
**Why**
----
To remove some vulnerabilities reported by Windows Defender and Virus Total.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgraded Go version an Go dependencies versions [brooklyn-client]
Posted by "ahgittin (via GitHub)" <gi...@apache.org>.
ahgittin commented on PR #104:
URL: https://github.com/apache/brooklyn-client/pull/104#issuecomment-2232885335
@iuliana probably the docker build image needs updated to use this version of go, otherwise the build will fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgraded Go version an Go dependencies versions [brooklyn-client]
Posted by "ahgittin (via GitHub)" <gi...@apache.org>.
ahgittin merged PR #104:
URL: https://github.com/apache/brooklyn-client/pull/104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgraded Go version an Go dependencies versions [brooklyn-client]
Posted by "jcabrerizo (via GitHub)" <gi...@apache.org>.
jcabrerizo commented on code in PR #104:
URL: https://github.com/apache/brooklyn-client/pull/104#discussion_r1680745037
##########
cli/go.mod:
##########
@@ -16,19 +16,19 @@
// under the License.
module github.com/apache/brooklyn-client/cli
-go 1.20
+go 1.22.5
Review Comment:
```suggestion
go 1.22
```
This makes the pipeline to fail with
```
invalid go version '1.22.5': must match format 1.23
```
Only the minor version must be defined
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Upgraded Go version an Go dependencies versions [brooklyn-client]
Posted by "iuliana (via GitHub)" <gi...@apache.org>.
iuliana commented on PR #104:
URL: https://github.com/apache/brooklyn-client/pull/104#issuecomment-2232887294
> @iuliana probably the docker build image needs updated to use this version of go, otherwise the build will fail?
oh...ok, I'll get right on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brooklyn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org