[GitHub] [superset] gforien commented on a diff in pull request #20883: feat(helm): support different replicaCount

[GitBox <gi...@apache.org>]

gforien commented on code in PR #20883:
URL: https://github.com/apache/superset/pull/20883#discussion_r931907199


##########
helm/superset/templates/deployment-worker.yaml:
##########
@@ -28,7 +28,11 @@ metadata:
     {{ toYaml .Values.supersetWorker.deploymentAnnotations | nindent 4 }}
 {{- end }}
 spec:
+  {{- if .Values.supersetWorker.replicaCount }}
+  replicas: {{ .Values.supersetWorker.replicaCount }}
+  {{- else }}

Review Comment:
   Ok so I did
   - remove `replicaCount` in the values, in the schema, and in the array of required values
   - add `supersetNode.replicaCount` and `supersetWorker.replicaCount` in the values, in the schema, and in the array of required values
   - edit the "Running on Kubernetes" doc



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org