You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "lostluck (via GitHub)" <gi...@apache.org> on 2023/03/31 17:43:45 UTC
[GitHub] [beam] lostluck opened a new pull request, #26054: [Go SDK] Update beam infra to Go 1.20.2
lostluck opened a new pull request, #26054:
URL: https://github.com/apache/beam/pull/26054
To ensure the boot loaders are built from the most up to date Go standard library version.
Also strips some needless version specifying in the self-hosted-runner set up. Go doesn't have the same runtime version issues Python and Java have, and should follow the latest Go version. Either the action needs Go or it doesn't.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775158
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775640
Run Python_PVR_Flink PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492590318
Weird... mongo db failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492631534
Run CommunityMetrics PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492631767
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775924
Run Website_Stage_GCS PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775545
Run Python_Dataframes PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775573
Run Python_Examples PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775304
Run Java_PVR_Flink_Docker PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775408
Run Kotlin_Examples PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492698589
Not entirely sure about the mongodb failures. It's like the splitting has changed somehow with the Go version, which is very weird.
https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Phrase/173/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775235
Run Java_Examples_Dataflow_Java17 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775854
Run SQL_Java17 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775267
Run Java_MongoDb_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492389990
Thanks! Merging once the tests pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492587918
Run Spotless PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492587551
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775611
Run Python_Integration PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492402541
## [Codecov](https://codecov.io/gh/apache/beam/pull/26054?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#26054](https://codecov.io/gh/apache/beam/pull/26054?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8539ccb) into [master](https://codecov.io/gh/apache/beam/commit/492e2c95f52915895b99ddc69038da1a91f006fa?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (492e2c9) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #26054 +/- ##
==========================================
- Coverage 71.44% 71.43% -0.01%
==========================================
Files 782 782
Lines 102847 102847
==========================================
- Hits 73474 73469 -5
- Misses 27897 27902 +5
Partials 1476 1476
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `79.96% <ø> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 6 files with indirect coverage changes](https://codecov.io/gh/apache/beam/pull/26054/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492631609
Run Go PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492698125
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492780062
Run Java_Spark3_Versions PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1493083817
@johannaojeling FYI, I think go 1.20 breaks use of generic coder functions, since the type names no longer keep their new types. This affects the mongodbio types you produced. It's happened due to the various generic/fixes in 1.20, but definitely an unexpected result here.
Raw output is here (search for `--- FAIL`): https://ci-beam.apache.org/job/beam_PreCommit_GoPortable_Phrase/189/consoleText
```
decoding custom coder name:"mongodbio.idRangeRestriction" type:{kind:EXTERNAL external_key:"github.com/apache/beam/sdks/v2/go/pkg/beam/io/mongodbio.idRangeRestriction"} enc:{name:"github.com/apache/beam/sdks/v2/go/pkg/beam/io/mongodbio.encodeBSON[...]" type:{kind:FUNC parameter_types:{kind:EXTERNAL external_key:"github.com/apache/beam/sdks/v2/go/pkg/beam/io/mongodbio.idRangeRestriction"} return_types:{kind:SLICE element:{kind:UINT8}} return_types:{kind:SPECIAL special:ERROR}}} dec:{name:"github.com/apache/beam/sdks/v2/go/pkg/beam/io/mongodbio.decodeBSON[...]" type:{kind:FUNC parameter_types:{kind:SLICE element:{kind:UINT8}} return_types:{kind:EXTERNAL external_key:"github.com/apache/beam/sdks/v2/go/pkg/beam/io/mongodbio.idRangeRestriction"} return_types:{kind:SPECIAL special:ERROR}}}
```
Basically the function/type name ends up as:
`github.com/apache/beam/sdks/v2/go/pkg/beam/io/mongodbio.encodeBSON[...]` for both the idRange and idRangeRestriction encode and decode functions.
I'll send out work around PR which just adds explicit wrapper functions for now. But this is certainly an unexpected side effect of the generic functions on beam's registrations...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck merged PR #26054:
URL: https://github.com/apache/beam/pull/26054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775332
Run Java_Parquet_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775821
Run SQL_Java11 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1493389461
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492631333
Run Java_Pulsar_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492637575
Run Java PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775683
Run Python_Runners PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775766
Run SQL PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johannaojeling commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "johannaojeling (via GitHub)" <gi...@apache.org>.
johannaojeling commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1493317968
> @johannaojeling FYI, I think go 1.20 breaks use of generic coder functions, since the type names no longer keep their new types. This affects the mongodbio types you produced. It's happened due to the various generic/fixes in 1.20, but definitely an unexpected result here.
Ah that's interesting. Thanks for identifying the issue and creating a workaround
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1493068235
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1493086039
https://github.com/apache/beam/issues/26066 filed for the generic coder issue which will be fixed out of band.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492697951
Run Java_Examples_Dataflow PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775521
Run Python_Coverage PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775432
Run Portable_Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775489
Run PythonDocs PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775467
Run Python PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492631686
Run GoPortable PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492587665
Run Java_Kafka_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775387
Run Java_Spark3_Versions PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775903
Run Typescript PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492775946
Run Whitespace PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492698013
Run Java_Examples_Dataflow_Java17 PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492697837
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1493080670
Run Go PostCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492363010
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #26054: [Go SDK] Update beam infra to Go 1.20.2
Posted by "lostluck (via GitHub)" <gi...@apache.org>.
lostluck commented on PR #26054:
URL: https://github.com/apache/beam/pull/26054#issuecomment-1492360751
R: @jrmccluskey as the release manager for 2.47
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org