You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "John Fang (JIRA)" <ji...@apache.org> on 2018/02/07 02:43:01 UTC

[jira] [Closed] (FLINK-8567) Maven-shade-plugin can't relocate Scala classes.

     [ https://issues.apache.org/jira/browse/FLINK-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

John Fang closed FLINK-8567.
----------------------------
    Resolution: Fixed

> Maven-shade-plugin can't relocate Scala classes.
> ------------------------------------------------
>
>                 Key: FLINK-8567
>                 URL: https://issues.apache.org/jira/browse/FLINK-8567
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API &amp; SQL
>    Affects Versions: 1.5.0
>            Reporter: John Fang
>            Priority: Major
>             Fix For: 2.0.0
>
>         Attachments: exclude_guava.patch
>
>
> Maven-shade-plugin only relocate java classes, but not Scala classes. I try to decompile flink-table jar, and find those guava path not beed relocated on those Scala classes. But flink job run normally for all time. Because flink-dist_${scala.binary.version}.jar contains the google guava and flink shaded guava at the same time. Why is the google guava still contained int the flink?
>  Because we build flink by Maven-assembly-plugin at flink-disk module. The Assembly Plugin aggregate its all dependencies, includes those dependencies which are shaded now. If we use the following patch which exclude the Guava, then the flink-dist_${scala.binary.version}.jar only contains the flink-shaded-guava, not the google guava.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)