[GitHub] [camel] davsclaus commented on a change in pull request #5311: Add proper endChoice() and end() blocks

[GitBox <gi...@apache.org>]

davsclaus commented on a change in pull request #5311:
URL: https://github.com/apache/camel/pull/5311#discussion_r611010767



##########
File path: core/camel-core-engine/src/main/docs/modules/eips/pages/choice-eip.adoc
##########
@@ -40,14 +40,49 @@ RouteBuilder builder = new RouteBuilder() {
             .choice()
                 .when(simple("${header.foo} == 'bar'"))
                     .to("direct:b")
+                .endChoice()
                 .when(simple("${header.foo} == 'cheese'"))
                     .to("direct:c")
+                .endChoice()

Review comment:
       Can you restore this example back to what it was before - this is 99% of the normal use-cases.
   
   And then below it would be good to add a header section about endChoice and then you can use the multicast example as its example.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org