You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2018/06/01 05:02:00 UTC
[jira] [Commented] (HBASE-20444) Improve version comparison logic
for HBase specific version string and add unit tests
[ https://issues.apache.org/jira/browse/HBASE-20444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16497557#comment-16497557 ]
Hudson commented on HBASE-20444:
--------------------------------
Results for branch branch-2
[build #808 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/808/]: (/) *{color:green}+1 overall{color}*
----
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/808//General_Nightly_Build_Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/808//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/808//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
> Improve version comparison logic for HBase specific version string and add unit tests
> -------------------------------------------------------------------------------------
>
> Key: HBASE-20444
> URL: https://issues.apache.org/jira/browse/HBASE-20444
> Project: HBase
> Issue Type: Improvement
> Components: util
> Reporter: Umesh Agashe
> Assignee: maoling
> Priority: Major
> Fix For: 3.0.0, 2.1.0, 1.5.0
>
> Attachments: HBASE-20444.addendum.0.patch, HBASE-20444.master.001.patch, HBASE-20444.master.002.patch, HBASE-20444.master.003.patch, HBASE-20444.master.004.patch
>
>
> As [~busbey] commented on HBASE-18792, current logic for comparing version strings in class org.apache.hadoop.hbase.util.VersionInfo is generic and needs to be improved:
> {code:java}
> if (index < s1.length) {
> // s1 is longer
> return 1;
> }
> {code}
> {quote}I think this is wrong? like version "2.0.0" should be after "2.0.0-SNAPSHOT". it's also after "2.0.0-alpha-3" or "2.0.0-beta-1".
> {quote}
> Also in other cases 2.0.0 should be before 2.0.0-patch-XXXX and 2.0.0.1. Also 2.0 should be before 2.0.1.
> {quote}Can we expand the versions checked in TestVersionInfo to include a) some "same major different minor", b) "same minor different maintenance", c) both of the above, but SNAPSHOT, d) "-alpha" / "-beta"?
> {quote}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)