You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucene.apache.org by "Diego Ceccarelli (Jira)" <ji...@apache.org> on 2019/11/12 16:35:00 UTC

[jira] [Created] (LUCENE-9042) Refactor TopGroups.merge tests

Diego Ceccarelli created LUCENE-9042:
----------------------------------------

             Summary: Refactor TopGroups.merge tests
                 Key: LUCENE-9042
                 URL: https://issues.apache.org/jira/browse/LUCENE-9042
             Project: Lucene - Core
          Issue Type: Improvement
            Reporter: Diego Ceccarelli


This task proposes a refactoring of the test coverage for the {{TopGroups.merge}} method implemented in LUCENE-9010. For now it will cover only 3 main cases. 
1. Merging to empty TopGroups
2. Merging a TopGroups with scores and a TopGroups without scores (currently broken because of LUCENE-8996 bug) 
3. Merging two TopGroups with scores.

I'm planning to increase the coverage testing also invalid inputs but I would do that in a separate PR to keep the code readable. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org