You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/18 03:01:28 UTC

[GitHub] [apisix] leslie-tsang opened a new pull request, #6871: chore: update centos support for `how-to-build` docs

leslie-tsang opened a new pull request, #6871:
URL: https://github.com/apache/apisix/pull/6871

   ### Description
   
   <!-- Please include a summary of the change and which issue is fixed. -->
   <!-- Please also include relevant motivation and context. -->
   
   Apache APISIX now support CentOS 8 repo, update the docs for it.
   
   ### Checklist
   
   - [x] I have explained the need for this PR and the problem it solves
   - [ ] I have explained the changes or the new features added to this PR
   - [ ] I have added tests corresponding to this change
   - [x] I have updated the documentation to reflect this change
   - [x] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
   
   <!--
   
   Note
   
   1. Mark the PR as draft until it's ready to be reviewed.
   2. Always add/update tests for any changes unless you have a good reason.
   3. Always update the documentation to reflect the changes made in the PR.
   4. Make a new commit to resolve conversations instead of `push -f`.
   5. To resolve merge conflicts, merge master instead of rebasing.
   6. Use "request review" to notify the reviewer after making changes.
   7. Only a reviewer can mark a conversation as resolved.
   
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] leslie-tsang merged pull request #6871: docs(how-to-build): update centos repo support

Posted by GitBox <gi...@apache.org>.
leslie-tsang merged PR #6871:
URL: https://github.com/apache/apisix/pull/6871


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] leslie-tsang commented on a diff in pull request #6871: docs(how-to-build): update centos repo support

Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on code in PR #6871:
URL: https://github.com/apache/apisix/pull/6871#discussion_r852556231


##########
docs/zh/latest/how-to-build.md:
##########
@@ -355,7 +355,7 @@ Content-Type: text/html
 
 ## 步骤 7 为 Apache APISIX 添加 systemd 配置文件
 
-如果您使用的操作系统是 CentOS 7，且在步骤 2 中通过 RPM 包安装 Apache APISIX，配置文件已经自动安装到位，你可以直接运行以下命令：
+如果您使用的操作系统是 CentOS，且在步骤 2 中通过 RPM 包安装 Apache APISIX，配置文件已经自动安装到位，你可以直接运行以下命令：

Review Comment:
   There seems to be no need to introduce personal pronoun.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] Baoyuantop commented on a diff in pull request #6871: docs(how-to-build): update centos repo support

Posted by GitBox <gi...@apache.org>.
Baoyuantop commented on code in PR #6871:
URL: https://github.com/apache/apisix/pull/6871#discussion_r852535544


##########
docs/en/latest/how-to-build.md:
##########
@@ -361,7 +361,7 @@ If you need these features, you can build APISIX OpenResty. You can refer to the
 
 ## Step 7: Add Systemd unit file for Apache APISIX
 
-If you are using CentOS 7 and you installed [Apache APISIX via the RPM package](#installation-via-rpm-repository-centos-7), the configuration file will already be in place and you can run the following command directly.
+If you are using CentOS and you installed [Apache APISIX via the RPM package](#installation-via-rpm-repository-centos), the configuration file will already be in place and you can run the following command directly.

Review Comment:
   ```suggestion
   If you were using CentOS and installed [Apache APISIX via the RPM package](#installation-via-rpm-repository-centos), the configuration file will already be in place, and you can run the following command directly.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] juzhiyuan commented on a diff in pull request #6871: docs(how-to-build): update centos repo support

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on code in PR #6871:
URL: https://github.com/apache/apisix/pull/6871#discussion_r852553865


##########
docs/zh/latest/how-to-build.md:
##########
@@ -355,7 +355,7 @@ Content-Type: text/html
 
 ## 步骤 7 为 Apache APISIX 添加 systemd 配置文件
 
-如果您使用的操作系统是 CentOS 7，且在步骤 2 中通过 RPM 包安装 Apache APISIX，配置文件已经自动安装到位，你可以直接运行以下命令：
+如果您使用的操作系统是 CentOS，且在步骤 2 中通过 RPM 包安装 Apache APISIX，配置文件已经自动安装到位，你可以直接运行以下命令：

Review Comment:
   `您？你？` I would prefer always using `你`。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] leslie-tsang commented on a diff in pull request #6871: docs(how-to-build): update centos repo support

Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on code in PR #6871:
URL: https://github.com/apache/apisix/pull/6871#discussion_r852555863


##########
docs/en/latest/how-to-build.md:
##########
@@ -361,7 +361,7 @@ If you need these features, you can build APISIX OpenResty. You can refer to the
 
 ## Step 7: Add Systemd unit file for Apache APISIX
 
-If you are using CentOS 7 and you installed [Apache APISIX via the RPM package](#installation-via-rpm-repository-centos-7), the configuration file will already be in place and you can run the following command directly.
+If you are using CentOS and you installed [Apache APISIX via the RPM package](#installation-via-rpm-repository-centos), the configuration file will already be in place and you can run the following command directly.

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] hf400159 commented on a diff in pull request #6871: chore: update centos support for `how-to-build` docs

Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #6871:
URL: https://github.com/apache/apisix/pull/6871#discussion_r851857872


##########
docs/en/latest/how-to-build.md:
##########
@@ -59,7 +57,7 @@ sudo yum install apisix
 sudo yum install apisix-2.10.3-0.el7
 ```
 
-### Installation via RPM Offline Package (CentOS 7)
+### Installation via RPM Offline Package (CentOS)

Review Comment:
   ```suggestion
   ### Installation via RPM Offline Package (CentOS)
   This installation method is suitable for CentOS 7 and CentOS 8.
   ```



##########
docs/en/latest/how-to-build.md:
##########
@@ -25,11 +25,9 @@ This guide walks you through how you can build and get Apache APISIX running on
 
 ## Step 1: Install Apache APISIX
 
-Apache APISIX can be installed via the [RPM package](#installation-via-rpm-repository-centos-7), [Docker image](#installation-via-docker), [Helm Chart](#installation-via-helm-chart) or the [source release package](#installation-via-source-release-package). You can install via any one of these options.
+Apache APISIX can be installed via the [RPM package](#installation-via-rpm-repository-centos), [Docker image](#installation-via-docker), [Helm Chart](#installation-via-helm-chart) or the [source release package](#installation-via-source-release-package). You can install via any one of these options.
 
-### Installation via RPM Repository (CentOS 7)
-
-This installation method is suitable for CentOS 7.
+### Installation via RPM Repository (CentOS)

Review Comment:
   ```suggestion
   ### Installation via RPM Repository (CentOS)
   This installation method is suitable for CentOS 7 and CentOS 8.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] hf400159 commented on a diff in pull request #6871: chore: update centos support for `how-to-build` docs

Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #6871:
URL: https://github.com/apache/apisix/pull/6871#discussion_r851856383


##########
docs/zh/latest/how-to-build.md:
##########
@@ -25,9 +25,7 @@ title: 如何构建 Apache APISIX
 
 你可以通过 RPM 仓库、Docker、Helm Chart、源码包、源码包（LTS 版本）等多种方式来安装 Apache APISIX。请在以下选项中选择其中一种执行。
 
-### 通过 RPM 仓库安装（CentOS 7）
-
-这种安装方式适用于 CentOS 7 操作系统。
+### 通过 RPM 仓库安装（CentOS）

Review Comment:
   ```suggestion
   ### 通过 RPM 仓库安装（CentOS）
   这种安装方式适用于 CentOS 7 和 CentOS 8 操作系统。
   ```



##########
docs/zh/latest/how-to-build.md:
##########
@@ -57,7 +55,7 @@ sudo yum install apisix
 sudo yum install apisix-2.10.3-0.el7
 ```
 
-### 通过 RPM 包离线安装（CentOS 7）
+### 通过 RPM 包离线安装（CentOS）

Review Comment:
   ```suggestion
   ### 通过 RPM 包离线安装（CentOS）
   这种安装方式适用于 CentOS 7 和 CentOS 8 操作系统。
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org