You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by da...@apache.org on 2016/11/17 00:17:01 UTC
kudu git commit: java-client: fix test execution-order race in
TestKuduTable
Repository: kudu
Updated Branches:
refs/heads/master 6be3f328a -> 895a4b766
java-client: fix test execution-order race in TestKuduTable
The test was checking the number of tables in the mini cluster, not
accounting for tables potentially leaked by other test cases.
Change-Id: I935a800d3d87ab2c3180ce589e1b6b5dd48f9d70
Reviewed-on: http://gerrit.cloudera.org:8080/5113
Reviewed-by: Jean-Daniel Cryans <jd...@apache.org>
Tested-by: Kudu Jenkins
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/895a4b76
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/895a4b76
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/895a4b76
Branch: refs/heads/master
Commit: 895a4b766fafd7e661dff9c3427727b46ab51ffb
Parents: 6be3f32
Author: Dan Burkert <da...@apache.org>
Authored: Wed Nov 16 15:48:54 2016 -0800
Committer: Dan Burkert <da...@apache.org>
Committed: Thu Nov 17 00:16:45 2016 +0000
----------------------------------------------------------------------
.../src/test/java/org/apache/kudu/client/TestKuduTable.java | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/895a4b76/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
----------------------------------------------------------------------
diff --git a/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java b/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
index 3634e95..ab0af26 100644
--- a/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
+++ b/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTable.java
@@ -133,6 +133,8 @@ public class TestKuduTable extends BaseKuduTest {
public void testGetLocations() throws Exception {
String table1 = name.getMethodName() + System.currentTimeMillis();
+ int initialTableCount = client.getTablesList().join(DEFAULT_SLEEP).getTablesList().size();
+
// Test a non-existing table
try {
openTable(table1);
@@ -222,7 +224,8 @@ public class TestKuduTable extends BaseKuduTest {
assertEquals(0, client.getTablesList(table1).join(DEFAULT_SLEEP).getTablesList().size());
assertEquals(1, client.getTablesList(tableWithDefault)
.join(DEFAULT_SLEEP).getTablesList().size());
- assertEquals(5, client.getTablesList().join(DEFAULT_SLEEP).getTablesList().size());
+ assertEquals(initialTableCount + 5,
+ client.getTablesList().join(DEFAULT_SLEEP).getTablesList().size());
assertFalse(client.getTablesList(tableWithDefault).
join(DEFAULT_SLEEP).getTablesList().isEmpty());