You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/16 11:01:47 UTC
[GitHub] [incubator-nuttx] zouboan opened a new pull request #5241: sparc-v8 coding style problem has modified
zouboan opened a new pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241
## Summary
I have modified all the coding style problem
I finished porting NuttX to SPARC V8 last year, Include architecture support code and board support code, I also verified the Tickless OS mode and ELF file separate load on SPARC V8 architecture
## Impact
Someone can run NuttX on AT697F(based on LEON 2)
## Testing
I have verified compile with apps and ELF file separate load.All this work has been tested on real hardware
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5241: Port nuttx to sparc-v8
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1014788972
@zouboan could you add sparc-v8 to the daily ci?
You can add the tool installation here:
https://github.com/apache/incubator-nuttx/blob/master/tools/ci/cibuild.sh#L49
and enable build here:
https://github.com/apache/incubator-nuttx/blob/master/tools/ci/testlist/other.dat
https://github.com/apache/incubator-nuttx/blob/master/tools/ci/testlist/all.dat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5241: Port nuttx to sparc-v8
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1014453469
"habemus spark v8" kudos @zouboan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on pull request #5241: sparc-v8 coding style problem has modified
Posted by GitBox <gi...@apache.org>.
zouboan commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1013897460
>
there are
pick dfc0d2f new commit
pick 4749b52 sparc
pick f06c035 new commit
pick a27fe14 new commit
pick 88aba2a sparc-v8
when i do git rebase --interactive HEAD~5
i't means i need replace them with "pick to squash" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5241: sparc-v8 coding style problem has modified
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1013920526
> ok,I finally done, now there is only one commit!
It's better to update the commit message to reflect the patch by:
```
git commit --amend
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on pull request #5241: sparc-v8 coding style problem has modified
Posted by GitBox <gi...@apache.org>.
zouboan commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1013890140
I'm not sure how to operate,but i have delete old branch before i push local code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on pull request #5241: Port nuttx to sparc-v8
Posted by GitBox <gi...@apache.org>.
zouboan commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1014662846
> "habemus spark v8" kudos @zouboan
I will try to support the SMP of leon 5 in future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #5241: sparc-v8 coding style problem has modified
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1013961589
Congratulations @zouboan you did it! Please just change commit message using "git commit --amend" as Mr Xiang suggest, because "new commit" is not a good name for a commit important like this! Hehehe
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5241: sparc-v8 coding style problem has modified
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1013886697
@zouboan could you squash all patch into one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5241: sparc-v8 coding style problem has modified
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1013892657
> I'm not sure how to operate,but i have delete old branch before i push local code
try this:
```
git rebase --interactive HEAD~5
and check pick to squash
refine the comment
git push -f origin fft
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on pull request #5241: sparc-v8 coding style problem has modified
Posted by GitBox <gi...@apache.org>.
zouboan commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1013905667
ok,I finally done, now there is only one commit!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #5241: Port nuttx to sparc-v8
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on pull request #5241: sparc-v8 coding style problem has modified
Posted by GitBox <gi...@apache.org>.
zouboan commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1013977490
ok, the commit message has been updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #5241: sparc-v8 coding style problem has modified
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1013961589
Congratulations @zouboan you did it! Please just change commit message using "git commit --amend" as Mr Xiang suggested and run "git push -f origin fft" again, because "new commit" is not a good name for a commit important like this! ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] zouboan commented on pull request #5241: Port nuttx to sparc-v8
Posted by GitBox <gi...@apache.org>.
zouboan commented on pull request #5241:
URL: https://github.com/apache/incubator-nuttx/pull/5241#issuecomment-1014993056
@xiaoxiang781216 ok, i will try it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org