You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/10/17 06:32:18 UTC

[GitHub] [lucenenet] nikcio commented on a diff in pull request #690: Review for CA1822: Mark members as static

nikcio commented on code in PR #690:
URL: https://github.com/apache/lucenenet/pull/690#discussion_r996657041


##########
src/Lucene.Net.Tests.Analysis.Phonetic/Language/MatchRatingApproachEncoderTest.cs:
##########
@@ -90,19 +90,19 @@ public void TestAccentRemoval_NullValue_ReturnNullSuccessfully()
         [Test]
         public void TestRemoveSingleDoubleConsonants_BUBLE_RemovedSuccessfully()
         {
-            Assert.AreEqual("BUBLE", this.StringEncoder.RemoveDoubleConsonants("BUBBLE"));
+            Assert.AreEqual("BUBLE", MatchRatingApproachEncoder.RemoveDoubleConsonants("BUBBLE"));

Review Comment:
   This has been reverted and methods used here have also been reverted to non-static.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org