You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudberry.apache.org by ma...@apache.org on 2025/02/26 06:21:34 UTC

(cloudberry) 01/08: Use ERROR for dispatcher liveness checks

This is an automated email from the ASF dual-hosted git repository.

maxyang pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudberry.git

commit 25c6dbb5a4b270306864711f2beab330cc3ed26e
Author: Soumyadeep Chakraborty <so...@gmail.com>
AuthorDate: Fri Mar 3 17:56:42 2023 -0800

    Use ERROR for dispatcher liveness checks
    
    COMMERROR doesn't fail the query. ERROR does. This was an oversight in
    fbde68090e7.
---
 contrib/interconnect/udp/ic_udpifc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/contrib/interconnect/udp/ic_udpifc.c b/contrib/interconnect/udp/ic_udpifc.c
index 8ef25fe96e..44f5f83fe7 100644
--- a/contrib/interconnect/udp/ic_udpifc.c
+++ b/contrib/interconnect/udp/ic_udpifc.c
@@ -6118,7 +6118,7 @@ dispatcherAYT(void)
 
 	if (MyProcPort->sock == PGINVALID_SOCKET)
 	{
-		ereport(COMMERROR,
+		ereport(ERROR,
 				(errcode(ERRCODE_GP_INTERCONNECTION_ERROR),
 				errmsg("backend socket is invalid (recv)"),
 				errdetail("it could already have been closed")));
@@ -6132,7 +6132,7 @@ dispatcherAYT(void)
 
 	if (ret == 0)				/* socket has been closed. EOF */
 	{
-		ereport(COMMERROR,
+		ereport(ERROR,
 				(errcode(ERRCODE_GP_INTERCONNECTION_ERROR),
 				errmsg("dispatch connection lost (recv)"),
 				errdetail("peer socket has been closed, eof received")));
@@ -6143,7 +6143,7 @@ dispatcherAYT(void)
 		if (errno == EAGAIN || errno == EINPROGRESS)
 			return;		/* connection intact, no data available */
 		else                    /* unrecoverable error */
-			ereport(COMMERROR,
+			ereport(ERROR,
 					(errcode(ERRCODE_GP_INTERCONNECTION_ERROR),
 					errmsg("dispatch connection lost (recv): %m")));
 	}


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cloudberry.apache.org
For additional commands, e-mail: commits-help@cloudberry.apache.org