You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/14 11:44:34 UTC

[GitHub] [shardingsphere] menghaoranss opened a new pull request #6348: Refactor orchestration facade

menghaoranss opened a new pull request #6348:
URL: https://github.com/apache/shardingsphere/pull/6348


   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking commented on a change in pull request #6348: Refactor orchestration facade

Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #6348:
URL: https://github.com/apache/shardingsphere/pull/6348#discussion_r454344033



##########
File path: shardingsphere-control-panel/shardingsphere-orchestration/shardingsphere-orchestration-core/shardingsphere-orchestration-core-facade/src/main/java/org/apache/shardingsphere/orchestration/core/facade/ShardingOrchestrationFacade.java
##########
@@ -57,84 +57,109 @@
         ShardingSphereServiceLoader.register(ConfigCenterRepository.class);
         ShardingSphereServiceLoader.register(RegistryCenterRepository.class);
     }
-
-    @Getter
-    private static ShardingOrchestrationFacade instance;
     
-    private final ConfigCenterRepository configCenterRepository;
+    private ConfigCenterRepository configCenterRepository;
     
-    private final RegistryCenterRepository registryCenterRepository;
+    private RegistryCenterRepository registryCenterRepository;
 
-    private final ConfigCenterRepository centerRepository;
+    private ConfigCenterRepository centerRepository;
     
     @Getter
-    private final boolean isOverwrite;
+    private boolean isOverwrite;
     
     @Getter
-    private final ConfigCenter configCenter;
+    private ConfigCenter configCenter;
     
     @Getter
-    private final RegistryCenter registryCenter;
+    private RegistryCenter registryCenter;
 
     @Getter
-    private final MetaDataCenter metaDataCenter;
+    private MetaDataCenter metaDataCenter;
+    
+    private ShardingOrchestrationListenerManager listenerManager;
+    
+    private String configCenterName;
+    
+    private String registryCenterName;
+    
+    private String metaDataCenterName;
     
-    private final ShardingOrchestrationListenerManager listenerManager;
+    /**
+     * Init orchestration facade.
+     *
+     * @param orchestrationConfig orchestration configuration
+     * @param shardingSchemaNames collection of sharding schema names
+     */
+    public void init(final OrchestrationConfiguration orchestrationConfig, final Collection<String> shardingSchemaNames) {

Review comment:
       good job




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] kimmking merged pull request #6348: Refactor orchestration facade

Posted by GitBox <gi...@apache.org>.
kimmking merged pull request #6348:
URL: https://github.com/apache/shardingsphere/pull/6348


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org