[GitHub] [logging-log4j2] remkop commented on a change in pull request #623: Remove Messge Lookups

[GitBox <gi...@apache.org>]

remkop commented on a change in pull request #623:
URL: https://github.com/apache/logging-log4j2/pull/623#discussion_r767411342



##########
File path: src/site/xdoc/manual/layouts.xml.vm
##########
@@ -1497,18 +1497,6 @@ WARN  [main]: Message 2</pre>
                   The call site can look like this:
                 </p>
                 <pre class="prettyprint linenums">logger.info("@|KeyStyle {}|@ = @|ValueStyle {}|@", entry.getKey(), entry.getValue());</pre>
-                <p>
-                  Use <code>{lookups}</code> to log messages like <code>logger.info("Try ${esc.d}{date:YYYY-MM-dd}")</code>

Review comment:
       Would it make sense to put a note here, something like this:
   
   > <p>From Log4j 2.16.0, support for lookups in log messages has been removed for security reasons. Both the <code>{lookups}</code> and the <code>{nolookups}</code> options on the <code>%m</code>,  <code>%msg</code> and  <code>%message</code> pattern are now silently ignored. </p>




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org