You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2020/08/17 17:32:28 UTC
[GitHub] [iceberg] edgarRd commented on a change in pull request #1334: Fix Error Prone ByteBuffer warnings
edgarRd commented on a change in pull request #1334:
URL: https://github.com/apache/iceberg/pull/1334#discussion_r471649805
##########
File path: data/src/main/java/org/apache/iceberg/data/orc/GenericOrcWriters.java
##########
@@ -231,7 +231,24 @@ public void nonNullWrite(int rowId, String data, ColumnVector output) {
@Override
public void nonNullWrite(int rowId, ByteBuffer data, ColumnVector output) {
- ((BytesColumnVector) output).setRef(rowId, data.array(), 0, data.array().length);
+ // We technically can't be sure if the ByteBuffer coming in is on or off
+ // heap so we cannot safely call `.array()` on it without first checking
+ // via the method ByteBuffer.hasArray().
+ // See: https://errorprone.info/bugpattern/ByteBufferBackingArray
+ //
+ // When there is a backing heap based byte array, we avoided the overhead of
+ // copying, which is especially important for small byte buffers.
+ //
+ // TODO - This copy slows it down, perhap unnecessarily. Is there any other way to tell, or no?
Review comment:
Right, I agree that when writing this `ByteBuffer` to a `BytesColumnVector` there was an assumption that it was backed by an array, but to support any `ByteBuffer` we need this handling here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org