You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/17 13:29:01 UTC

[GitHub] [airflow] uranusjr commented on a diff in pull request #25764: Remove depreciation warning when use default remote tasks logging handlers

uranusjr commented on code in PR #25764:
URL: https://github.com/apache/airflow/pull/25764#discussion_r947933943


##########
airflow/config_templates/airflow_local_settings.py:
##########
@@ -56,7 +56,10 @@
     'logging', 'DAG_PROCESSOR_MANAGER_LOG_LOCATION'
 )
 
-FILENAME_TEMPLATE: str = conf.get_mandatory_value('logging', 'LOG_FILENAME_TEMPLATE')
+# FILENAME_TEMPLATE only uses in Remote Logging Handlers since Airflow 2.3.3
+# All of these handlers inherited from FileTaskHandler and providing any value rather than None
+# would raise deprecation warning.
+FILENAME_TEMPLATE: Optional[str] = None

Review Comment:
   It shouldn’t be used anywhere else (should just read from `conf`). This can be removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org