You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/07 19:54:07 UTC
[GitHub] [airflow] bbovenzi opened a new pull request #15258: use jquery ready instead of vanilla js
bbovenzi opened a new pull request #15258:
URL: https://github.com/apache/airflow/pull/15258
This is a band-aid fix for #15103
Switching the 'has the document loaded' function removes a phantom `onChange` event from firing and submitting the form when the page loads and changing the url.
What is really happening is that the datetimepicker doesn't have millisecond precision (nor should it from a UX perspective), but getting logs do require millisecond precision. Even being 1 millisecond off will not load logs. Therefore any manipulation of the datetimepicker will still break logs. Long term, we should go down to at least second precision, if not even moreso.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ryanahamilton merged pull request #15258: Prevent datepicker submit on page load
Posted by GitBox <gi...@apache.org>.
ryanahamilton merged pull request #15258:
URL: https://github.com/apache/airflow/pull/15258
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #15258: Prevent datepicker submit on page load
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15258:
URL: https://github.com/apache/airflow/pull/15258#issuecomment-815242895
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org