You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/12/05 23:36:35 UTC
[Apache Bloodhound] #286: Project description text on Basic
Settings has leading whitespace
#286: Project description text on Basic Settings has leading whitespace
-----------------------+-----------------------
Reporter: rjollos | Owner: rjollos
Type: defect | Status: new
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Keywords: settings |
-----------------------+-----------------------
[[Image(ProjectSettings-Description.png)]]
This can be addressed with the following patch:
{{{
#!patch
Index: bloodhound_theme/bhtheme/templates/bh_admin_basics.html
===================================================================
--- bloodhound_theme/bhtheme/templates/bh_admin_basics.html (revision
1417310)
+++ bloodhound_theme/bhtheme/templates/bh_admin_basics.html (working
copy)
@@ -49,8 +49,8 @@
<div class="control-group">
<label class="control-label" for="descr">Description:</label>
<div class="controls">
- <textarea id="descr" name="descr" class="trac-resizable"
rows="3" cols="50">
- ${project.descr}</textarea>
+ <textarea id="descr" name="descr" class="trac-resizable"
+ rows="3" cols="50">${project.descr}</textarea>
</div>
</div>
<div class="control-group">
}}}
In the Trac core, they deal with the issue by not indenting the line:
{{{
#!python
<textarea name="descr" class="trac-resizable" rows="3"
cols="50">
${project.descr}</textarea>
}}}
I tend to think the above patch is better stylistically, but I'll wait for
feedback from others before committing.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/286>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #286: Project description text on Basic
Settings has leading whitespace
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#286: Project description text on Basic Settings has leading whitespace
------------------------+-----------------------
Reporter: rjollos | Owner: rjollos
Type: defect | Status: closed
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: fixed | Keywords: settings
------------------------+-----------------------
Changes (by rjollos):
* status: review => closed
* resolution: => fixed
Comment:
Committed in r1418195.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/286#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #286: Project description text on Basic
Settings has leading whitespace
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#286: Project description text on Basic Settings has leading whitespace
------------------------+-----------------------
Reporter: rjollos | Owner: olemis
Type: defect | Status: review
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: settings
------------------------+-----------------------
Changes (by olemis):
* owner: rjollos => olemis
* status: accepted => review
Comment:
I'll review your patch asap .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/286#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #286: Project description text on Basic
Settings has leading whitespace
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#286: Project description text on Basic Settings has leading whitespace
------------------------+-----------------------
Reporter: rjollos | Owner: rjollos
Type: defect | Status: review
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: settings
------------------------+-----------------------
Changes (by gjm):
* owner: gjm => rjollos
Comment:
Good to commit as far as I am concerned.
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/286#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #286: Project description text on Basic
Settings has leading whitespace
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#286: Project description text on Basic Settings has leading whitespace
------------------------+-----------------------
Reporter: rjollos | Owner: rjollos
Type: defect | Status: accepted
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: settings
------------------------+-----------------------
Changes (by rjollos):
* status: new => accepted
Old description:
> [[Image(ProjectSettings-Description.png)]]
>
> This can be addressed with the following patch:
> {{{
> #!patch
> Index: bloodhound_theme/bhtheme/templates/bh_admin_basics.html
> ===================================================================
> --- bloodhound_theme/bhtheme/templates/bh_admin_basics.html (revision
> 1417310)
> +++ bloodhound_theme/bhtheme/templates/bh_admin_basics.html (working
> copy)
> @@ -49,8 +49,8 @@
> <div class="control-group">
> <label class="control-label" for="descr">Description:</label>
> <div class="controls">
> - <textarea id="descr" name="descr" class="trac-resizable"
> rows="3" cols="50">
> - ${project.descr}</textarea>
> + <textarea id="descr" name="descr" class="trac-resizable"
> + rows="3" cols="50">${project.descr}</textarea>
> </div>
> </div>
> <div class="control-group">
> }}}
>
> In the Trac core, they deal with the issue by not indenting the line:
> {{{
> #!python
> <textarea name="descr" class="trac-resizable" rows="3"
> cols="50">
> ${project.descr}</textarea>
> }}}
>
> I tend to think the above patch is better stylistically, but I'll wait
> for feedback from others before committing.
New description:
[[Image(ProjectSettings-Description.png)]]
This can be addressed with the following patch:
{{{
#!diff
Index: bloodhound_theme/bhtheme/templates/bh_admin_basics.html
===================================================================
--- bloodhound_theme/bhtheme/templates/bh_admin_basics.html (revision
1417310)
+++ bloodhound_theme/bhtheme/templates/bh_admin_basics.html (working
copy)
@@ -49,8 +49,8 @@
<div class="control-group">
<label class="control-label" for="descr">Description:</label>
<div class="controls">
- <textarea id="descr" name="descr" class="trac-resizable"
rows="3" cols="50">
- ${project.descr}</textarea>
+ <textarea id="descr" name="descr" class="trac-resizable"
+ rows="3" cols="50">${project.descr}</textarea>
</div>
</div>
<div class="control-group">
}}}
In the Trac core, they deal with the issue by not indenting the line:
{{{
#!python
<textarea name="descr" class="trac-resizable" rows="3"
cols="50">
${project.descr}</textarea>
}}}
I tend to think the above patch is better stylistically, but I'll wait for
feedback from others before committing.
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/286#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #286: Project description text on Basic
Settings has leading whitespace
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#286: Project description text on Basic Settings has leading whitespace
------------------------+-----------------------
Reporter: rjollos | Owner: rjollos
Type: defect | Status: accepted
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: settings
------------------------+-----------------------
Description changed by rjollos:
Old description:
> [[Image(ProjectSettings-Description.png)]]
>
> This can be addressed with the following patch:
> {{{
> #!diff
> Index: bloodhound_theme/bhtheme/templates/bh_admin_basics.html
> ===================================================================
> --- bloodhound_theme/bhtheme/templates/bh_admin_basics.html (revision
> 1417310)
> +++ bloodhound_theme/bhtheme/templates/bh_admin_basics.html (working
> copy)
> @@ -49,8 +49,8 @@
> <div class="control-group">
> <label class="control-label" for="descr">Description:</label>
> <div class="controls">
> - <textarea id="descr" name="descr" class="trac-resizable"
> rows="3" cols="50">
> - ${project.descr}</textarea>
> + <textarea id="descr" name="descr" class="trac-resizable"
> + rows="3" cols="50">${project.descr}</textarea>
> </div>
> </div>
> <div class="control-group">
> }}}
>
> In the Trac core, they deal with the issue by not indenting the line:
> {{{
> #!python
> <textarea name="descr" class="trac-resizable" rows="3"
> cols="50">
> ${project.descr}</textarea>
> }}}
>
> I tend to think the above patch is better stylistically, but I'll wait
> for feedback from others before committing.
New description:
[[Image(ProjectSettings-Description.png)]]
This can be addressed with the following [attachment:t286-r1415767-1.patch
patch].
In the Trac core, they deal with the issue by
[http://trac.edgewall.org/browser/trunk/trac/admin/templates/admin_basics.html?rev=10571&marks=30-31#L28
not indenting the line].
I tend to think the above patch is better stylistically, but I'll wait for
feedback from others before committing.
--
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/286#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker
Re: [Apache Bloodhound] #286: Project description text on Basic
Settings has leading whitespace
Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#286: Project description text on Basic Settings has leading whitespace
------------------------+-----------------------
Reporter: rjollos | Owner: gjm
Type: defect | Status: review
Priority: trivial | Milestone: Release 4
Component: ui design | Version:
Resolution: | Keywords: settings
------------------------+-----------------------
Changes (by olemis):
* owner: olemis => gjm
Comment:
+1
/me forwarding for further review .
--
Ticket URL: <https://issues.apache.org/bloodhound/ticket/286#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker