You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Michael Semb Wever (Jira)" <ji...@apache.org> on 2022/11/09 10:58:00 UTC

[jira] [Comment Edited] (CASSANDRA-17768) Restore streaming_keep_alive_period functionality on the netty control streaming channel

    [ https://issues.apache.org/jira/browse/CASSANDRA-17768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17630980#comment-17630980 ] 

Michael Semb Wever edited comment on CASSANDRA-17768 at 11/9/22 10:57 AM:
--------------------------------------------------------------------------

Note, the new Messaging System (4.0) [does not|https://issues.apache.org/jira/browse/CASSANDRA-15066?focusedCommentId=16801284&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16801284] support mix-version (by [MS versions|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/MessagingService.java#L201]) streaming [anymore|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java#L298-L305].


was (Author: michaelsembwever):
Note, the new Messaging System (4.0) [does not|https://issues.apache.org/jira/browse/CASSANDRA-15066?focusedCommentId=16801284&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16801284] support mix-version streaming [anymore|https://github.com/apache/cassandra/blob/cassandra-4.0/src/java/org/apache/cassandra/net/InboundConnectionInitiator.java#L298-L305].

> Restore streaming_keep_alive_period functionality on the netty control streaming channel
> ----------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17768
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17768
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Legacy/Streaming and Messaging
>            Reporter: Ekaterina Dimitrova
>            Assignee: Aleksey Yeschenko
>            Priority: Normal
>             Fix For: 4.1-rc
>
>
> While working on another ticket I noticed that after [CASSANDRA-16927] CEP-10 Phase 1: Refactor Streaming 
> streaming_keep_alive_period is not used anymore, except to print it in error message [here|https://github.com/apache/cassandra/blob/cassandra-4.1/src/java/org/apache/cassandra/streaming/StreamSession.java#L689]
> If the property should not be used anymore, we need to deprecate it and fix the error message as it is misleading.
> [~benedict] , [~samt] , [~aleksey] , can you, please, check and take care of this one as authors of that patch?
> Thank you in advance!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org