You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by onlychoice <gi...@git.apache.org> on 2015/01/28 13:49:30 UTC

[GitHub] storm pull request: Fix java code error in doc

GitHub user onlychoice opened a pull request:

    https://github.com/apache/storm/pull/399

    Fix java code error in doc

    MyFilter should extends BaseFilter not BaseFunction.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/onlychoice/storm fix_doc

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/399.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #399
    
----
commit 40a6cf08cdf6f4269e7e41d3c7d8026e340767da
Author: Zhihui Jiao <zh...@gmail.com>
Date:   2015-01-28T12:48:22Z

    Fix java code error in doc

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Fix java code error in doc

Posted by d2r <gi...@git.apache.org>.

Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/399#issuecomment-74704890
  
    Thanks @onlychoice, I merged this to master. If you would like proper attribution in JIRA, please post your jira user name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Fix java code error in doc

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/399


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: Fix java code error in doc

Posted by d2r <gi...@git.apache.org>.

Github user d2r commented on the pull request:

    https://github.com/apache/storm/pull/399#issuecomment-74702594
  
    Filed [STORM-672](https://issues.apache.org/jira/browse/STORM-672).
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---