You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "emissionnebula (via GitHub)" <gi...@apache.org> on 2023/02/21 08:46:07 UTC

[GitHub] [kafka] emissionnebula opened a new pull request, #13282: KAKFA-14733: Update AclAuthorizerTest to run tests for both zk and kraft

emissionnebula opened a new pull request, #13282:
URL: https://github.com/apache/kafka/pull/13282

   AclAuthorizerTest includes a lot of tests covering various scenarios that are missing in StandardAuthorizerTest. 
   
   This PR changes the AclAuthorizerTest to run tests for both zk and kraft modes - 
   * Rename AclAuthorizerTest -> AuthorizerTest
   * Parameterize relevant tests to run for both modes
   
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] omkreddy merged pull request #13282: KAKFA-14733: Added a few missing checks for Kraft Authorizer and updated AclAuthorizerTest to run tests for both zk and kraft

Posted by "omkreddy (via GitHub)" <gi...@apache.org>.
omkreddy merged PR #13282:
URL: https://github.com/apache/kafka/pull/13282


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] emissionnebula commented on pull request #13282: KAKFA-14733: Added a few missing checks for Kraft Authorizer and updated AclAuthorizerTest to run tests for both zk and kraft

Posted by "emissionnebula (via GitHub)" <gi...@apache.org>.
emissionnebula commented on PR #13282:
URL: https://github.com/apache/kafka/pull/13282#issuecomment-1438402661

   Thanks @omkreddy for the review. I have updated the description. 
   
   Also, the build seems to be failing due to unrelated test failures. 
   - `org.apache.kafka.connect.mirror.integration.MirrorConnectorsIntegrationBaseTest.testReplication()` - java.lang.RuntimeException: Could not find enough records. found 0, expected 1
   - `org.apache.kafka.connect.mirror.integration.DedicatedMirrorIntegrationTest.testMultiNodeCluster()` - org.opentest4j.AssertionFailedError: Condition not met within timeout 30000. topic A.test-topic-0 was not created on cluster B- ._~:/?#[]@!$&'()*+;="<>%{}|\^‘618 in time ==> expected: <true> but was: <false>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [kafka] omkreddy commented on pull request #13282: KAKFA-14733: Added a few missing checks for Kraft Authorizer and updated AclAuthorizerTest to run tests for both zk and kraft

Posted by "omkreddy (via GitHub)" <gi...@apache.org>.
omkreddy commented on PR #13282:
URL: https://github.com/apache/kafka/pull/13282#issuecomment-1438537221

   Merged to trunk and 3.4


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org