You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by anoopsharma00 <gi...@git.apache.org> on 2016/03/17 21:02:28 UTC
[GitHub] incubator-trafodion pull request: JIRA 1899, Various fixes. Detail...
GitHub user anoopsharma00 opened a pull request:
https://github.com/apache/incubator-trafodion/pull/391
JIRA 1899, Various fixes. Details below.
-- time datatype with no fraction precision was not getting converted
correctly and was putting out null characters.
-- dateformat usa was not displaying AM/PM with time datatype
-- update of primary key that got transformed into delete/insert
would incorrectly delete the row if insert ran into an error
-- rename cascade option is not supported. An error is now returned.
-- rename table with check constraint is not supported.
An error is now returned.
-- add/drop of primary key constraint now gives consistent behavior.
Primary key columns are used as clustering key if primary key constraint
is specified during create table.
Primary key constraint creates a unique index if it is specified
after create table and no user specified primary or store by clause
was specified during create.
Drop of primary key constraint succeeds only if that primary key
is not the clustering key.
-- invalid ddl with salt clause no longer crashes and returns an error instead.
-- parser now gives a syntax error on MV and Triggers queries since
these features are not externalized.
-- regress/seabase/TEST031 has been added for misc fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/anoopsharma00/incubator-trafodion ansharma_fixes_br
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/391.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #391
----
commit 7c7ca5f3941f6a6d2141b1b91dac5c70e81d210f
Author: Cloud User <ce...@ansharma-2.novalocal>
Date: 2016-03-17T19:59:28Z
JIRA 1899, Various fixes. Details below.
-- time datatype with no fraction precision was not getting converted
correctly and was putting out null characters.
-- dateformat usa was not displaying AM/PM with time datatype
-- update of primary key that got transformed into delete/insert
would incorrectly delete the row if insert ran into an error
-- rename cascade option is not supported. An error is now returned.
-- rename table with check constraint is not supported.
An error is now returned.
-- add/drop of primary key constraint now gives consistent behavior.
Primary key columns are used as clustering key if primary key constraint
is specified during create table.
Primary key constraint creates a unique index if it is specified
after create table and no user specified primary or store by clause
was specified during create.
Drop of primary key constraint succeeds only if that primary key
is not the clustering key.
-- invalid ddl with salt clause no longer crashes and returns an error instead.
-- parser now gives a syntax error on MV and Triggers queries since
these features are not externalized.
-- regress/seabase/TEST031 has been added for misc fixes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: JIRA 1899, Various fixes. Detail...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---