You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2023/11/08 08:30:13 UTC
[PR] [SPARK-42821][SQL] Remove unused parameters in splitFiles methods [spark]
panbingkun opened a new pull request, #40454:
URL: https://github.com/apache/spark/pull/40454
### What changes were proposed in this pull request?
The pr aims to remove unused parameters in PartitionedFileUtil.splitFiles methods
### Why are the changes needed?
Make the code more concise.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Pass GA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42821][SQL] Remove unused parameters in splitFiles methods [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40454:
URL: https://github.com/apache/spark/pull/40454#issuecomment-1802664737
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #40454: [SPARK-42821][SQL] Remove unused parameters in splitFiles methods
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen commented on PR #40454:
URL: https://github.com/apache/spark/pull/40454#issuecomment-1473042762
Not a public API but probably not worth 'fixing' before spark 4 indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40454: [SPARK-42821][SQL] Remove unused parameters in splitFiles methods
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40454:
URL: https://github.com/apache/spark/pull/40454#issuecomment-1473029179
Personally, I think it's definitely possible to change it in Spark 4.0, but I wasn't sure before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #40454: [SPARK-42821][SQL] Remove unused parameters in splitFiles methods
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #40454:
URL: https://github.com/apache/spark/pull/40454#issuecomment-1472312946
This function a bit special, It was discussed a long time ago ...
https://github.com/apache/spark/pull/37862#issuecomment-1249419779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #40454: [SPARK-42821][SQL] Remove unused parameters in splitFiles methods
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #40454:
URL: https://github.com/apache/spark/pull/40454#issuecomment-1473058514
> Not a public API but probably not worth 'fixing' before spark 4 indeed
OK, Let's fix it after spark 4 release.
I will close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun commented on pull request #40454: [SPARK-42821][SQL] Remove unused parameters in splitFiles methods
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #40454:
URL: https://github.com/apache/spark/pull/40454#issuecomment-1472972319
> This function a bit special, It was discussed a long time ago ... [#37862 (comment)](https://github.com/apache/spark/pull/37862#issuecomment-1249419779)
If it's a public API, we should mark it; If not, we should correct our problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] panbingkun closed pull request #40454: [SPARK-42821][SQL] Remove unused parameters in splitFiles methods
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun closed pull request #40454: [SPARK-42821][SQL] Remove unused parameters in splitFiles methods
URL: https://github.com/apache/spark/pull/40454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42821][SQL] Remove unused parameters in splitFiles methods [spark]
Posted by "srowen (via GitHub)" <gi...@apache.org>.
srowen closed pull request #40454: [SPARK-42821][SQL] Remove unused parameters in splitFiles methods
URL: https://github.com/apache/spark/pull/40454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org