You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stu Hood (JIRA)" <ji...@apache.org> on 2011/04/21 02:13:05 UTC
[jira] [Created] (CASSANDRA-2524) Use SSTableBoundedScanner for
cleanup
Use SSTableBoundedScanner for cleanup
-------------------------------------
Key: CASSANDRA-2524
URL: https://issues.apache.org/jira/browse/CASSANDRA-2524
Project: Cassandra
Issue Type: Improvement
Reporter: Stu Hood
SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing cleanup.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2524) Use SSTableBoundedScanner for
cleanup
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2524:
--------------------------------------
Labels: lhf (was: )
> Use SSTableBoundedScanner for cleanup
> -------------------------------------
>
> Key: CASSANDRA-2524
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2524
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Priority: Minor
> Labels: lhf
>
> SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing per-key filtering that cleanup does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2524) Use SSTableBoundedScanner for
cleanup
Posted by "Stu Hood (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2524:
--------------------------------
Description: SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing per-key filtering that cleanup does. (was: SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing cleanup.)
> Use SSTableBoundedScanner for cleanup
> -------------------------------------
>
> Key: CASSANDRA-2524
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2524
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
>
> SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing per-key filtering that cleanup does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2524) Use SSTableBoundedScanner for
cleanup
Posted by "Stu Hood (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2524:
--------------------------------
Attachment: 0002-Oops.-When-indexes-or-counters-are-in-use-must-continu.txt
Oops... secondary indexes and counters actually still require a full scan to stay consistent after cleanup. 0002 Adds CleanupStrategy.
> Use SSTableBoundedScanner for cleanup
> -------------------------------------
>
> Key: CASSANDRA-2524
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2524
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Labels: lhf
> Attachments: 0001-Use-a-SSTableBoundedScanner-for-cleanup-and-improve-cl.txt, 0002-Oops.-When-indexes-or-counters-are-in-use-must-continu.txt
>
>
> SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing per-key filtering that cleanup does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2524) Use SSTableBoundedScanner for
cleanup
Posted by "Sylvain Lebresne (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127403#comment-13127403 ]
Sylvain Lebresne commented on CASSANDRA-2524:
---------------------------------------------
This looks good to me, though one thing that goes away with that is that for cf that use the BoundedScanner, we don't cleanup the row cache. This is not a really big deal, but it's perfectly possible that following the cleanup, rows that are still on the node get evicted from cache before rows that are not in the ranges of the node, so it's a slight regression. Maybe we could simply add a cache cleanup that iterate through the cache and only keeps keys in range? Though one may argue it's on the fringe of this ticket, I'd prefer we add this here so we commit something that is an improvement, rather than an improvement with a slight regression to be fixed later.
> Use SSTableBoundedScanner for cleanup
> -------------------------------------
>
> Key: CASSANDRA-2524
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2524
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Labels: lhf
> Attachments: 0001-Use-a-SSTableBoundedScanner-for-cleanup-and-improve-cl.txt, 0002-Oops.-When-indexes-or-counters-are-in-use-must-continu.txt
>
>
> SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing per-key filtering that cleanup does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2524) Use SSTableBoundedScanner for
cleanup
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-2524:
--------------------------------------
Priority: Minor (was: Major)
> Use SSTableBoundedScanner for cleanup
> -------------------------------------
>
> Key: CASSANDRA-2524
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2524
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Priority: Minor
>
> SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing per-key filtering that cleanup does.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (CASSANDRA-2524) Use SSTableBoundedScanner for
cleanup
Posted by "Stu Hood (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood reassigned CASSANDRA-2524:
-----------------------------------
Assignee: Stu Hood
> Use SSTableBoundedScanner for cleanup
> -------------------------------------
>
> Key: CASSANDRA-2524
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2524
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Labels: lhf
>
> SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing per-key filtering that cleanup does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2524) Use SSTableBoundedScanner for
cleanup
Posted by "Stu Hood (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stu Hood updated CASSANDRA-2524:
--------------------------------
Attachment: 0001-Use-a-SSTableBoundedScanner-for-cleanup-and-improve-cl.txt
Very, very simple change to use SSTableBoundedScanner during cleanup. The bulk of the patch is test changes.
> Use SSTableBoundedScanner for cleanup
> -------------------------------------
>
> Key: CASSANDRA-2524
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2524
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Stu Hood
> Assignee: Stu Hood
> Priority: Minor
> Labels: lhf
> Attachments: 0001-Use-a-SSTableBoundedScanner-for-cleanup-and-improve-cl.txt
>
>
> SSTableBoundedScanner seeks rather than scanning through rows, so it would be significantly more efficient than the existing per-key filtering that cleanup does.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira