You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/06/18 15:53:39 UTC

Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67634/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

It is no longer needed, since the macro is now directly
defined in json.hpp.


Diffs
-----

  3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
  src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 


Diff: https://reviews.apache.org/r/67634/diff/1/


Testing
-------


Thanks,

Benno Evers

Re: Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

Posted by Mesos Reviewbot <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67634/#review204934
-----------------------------------------------------------



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing list.

- Mesos Reviewbot


On June 18, 2018, 3:53 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67634/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 3:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It is no longer necessary, since the macro is now defined
> directly within <stout/json.hpp>.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
> 
> 
> Diff: https://reviews.apache.org/r/67634/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67634/#review205305
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On June 18, 2018, 8:53 a.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67634/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 8:53 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It is no longer necessary, since the macro is now defined
> directly within <stout/json.hpp>.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
> 
> 
> Diff: https://reviews.apache.org/r/67634/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

Posted by Benjamin Bannier <be...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67634/#review205362
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On June 18, 2018, 5:53 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67634/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 5:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It is no longer needed, since the macro is now directly
> defined in json.hpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   mesos.pc.in 61d6d0b2883f1893100c8aa0f309c2d27de4ea14 
>   src/Makefile.am 2f7f7f8b8683fc9ecd5685d28d36bd17f7e4a24a 
> 
> 
> Diff: https://reviews.apache.org/r/67634/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67634/#review204939
-----------------------------------------------------------



PASS: Mesos patch 67634 was successfully built and tested.

Reviews applied: `['67632', '67633', '67634']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67634

- Mesos Reviewbot Windows


On June 18, 2018, 3:53 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67634/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 3:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It is no longer necessary, since the macro is now defined
> directly within <stout/json.hpp>.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
> 
> 
> Diff: https://reviews.apache.org/r/67634/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67634/#review205370
-----------------------------------------------------------



PASS: Mesos patch 67634 was successfully built and tested.

Reviews applied: `['67632', '67633', '67634']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67634

- Mesos Reviewbot Windows


On June 18, 2018, 3:53 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67634/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 3:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It is no longer needed, since the macro is now directly
> defined in json.hpp.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   mesos.pc.in 61d6d0b2883f1893100c8aa0f309c2d27de4ea14 
>   src/Makefile.am 2f7f7f8b8683fc9ecd5685d28d36bd17f7e4a24a 
> 
> 
> Diff: https://reviews.apache.org/r/67634/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67634: Removed PICOJSON_USE_INT64 from Mesos build system.

Posted by Benjamin Bannier <be...@mesosphere.io>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67634/#review204993
-----------------------------------------------------------


Ship it!




Thanks for the cleanup, Benno!

Could you update the _Testing done_ section documenting that this patch can only be tested after one has also applied https://reviews.apache.org/r/67633/ and https://reviews.apache.org/r/67632/?

- Benjamin Bannier


On June 18, 2018, 5:53 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67634/
> -----------------------------------------------------------
> 
> (Updated June 18, 2018, 5:53 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> It is no longer necessary, since the macro is now defined
> directly within <stout/json.hpp>.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
> 
> 
> Diff: https://reviews.apache.org/r/67634/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Benno Evers
> 
>