You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/16 12:28:40 UTC
[GitHub] [incubator-tvm] jcf94 opened a new pull request #6077: [Ansor][AutoTVM v2.0] Part 1: Add RPC Runner
jcf94 opened a new pull request #6077:
URL: https://github.com/apache/incubator-tvm/pull/6077
For full upstream plan, see [Ansor RFC](https://discuss.tvm.ai/t/rfc-ansor-an-auto-scheduler-for-tvm-autotvm-v2-0/7005/32).
In this PR, we bring the RPCRunner. This uses RPC call to measures the time cost of programs on remote devices. And this can also be used in local running to insulate the thread environment.
The RPCRunner is critical for measuring schedules in ARM CPU and NVIDIA GPU.
p.s. This implementation is almost the same with what in AutoTVM's code base, will consider to merge them later.
cc @tqchen @merrymercy @FrozenGene @minminsun @comaniac
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jcf94 commented on a change in pull request #6077: [Ansor][AutoTVM v2.0] Phase 1: Add RPC Runner
Posted by GitBox <gi...@apache.org>.
jcf94 commented on a change in pull request #6077:
URL: https://github.com/apache/incubator-tvm/pull/6077#discussion_r456766397
##########
File path: tests/python/unittest/test_auto_scheduler_measure.py
##########
@@ -67,6 +67,26 @@ def test_measure_local_builder_runner():
assert mress[0].error_no == 0
+def test_measure_local_builder_rpc_runner():
+ dag, s0 = get_tiled_matmul()
+
+ if not tvm.runtime.enabled("llvm"):
+ return
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] FrozenGene commented on pull request #6077: [Ansor][AutoTVM v2.0] Phase 1: Add RPC Runner
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on pull request #6077:
URL: https://github.com/apache/incubator-tvm/pull/6077#issuecomment-659787345
> > @jcf94 Gental reminder: To reproduce Ansor paper's result, we should turn on clflush (for x86 cpu) and non empty array. clflush has been merged, you should consider to put it in this pr([clflush link](https://github.com/apache/incubator-tvm/pull/5914), non empty array pr I will do it as soon as possile. If that can not be merged before this pr, I could handle it after this pr is merged. Wish this info could make you aware we have some depentcy. Thanks.
>
>
>
> Ok, actually this is the least important part of phase 1.
>
> We can left this PR later, or I think it does seem better for you to fix the non empty & clflush parts after this PR. I'll add some TODO hints in the code.
fine. We could add TODO now and I could handle it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] FrozenGene commented on pull request #6077: [Ansor][AutoTVM v2.0] Part 1: Add RPC Runner
Posted by GitBox <gi...@apache.org>.
FrozenGene commented on pull request #6077:
URL: https://github.com/apache/incubator-tvm/pull/6077#issuecomment-659512977
@jcf94 Gental reminder: To reproduce Ansor paper's result, we should turn on clflush (for x86 cpu) and non empty array. clflush has been merged, you should consider to put it in this pr([clflush link](https://github.com/apache/incubator-tvm/pull/5914), non empty array pr I will do it as soon as possile. If that can not be merged before this pr, I could handle it after this pr is merged. Wish this info could make you aware we have some depentcy. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on a change in pull request #6077: [Ansor][AutoTVM v2.0] Phase 1: Add RPC Runner
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #6077:
URL: https://github.com/apache/incubator-tvm/pull/6077#discussion_r456695376
##########
File path: tests/python/unittest/test_auto_scheduler_measure.py
##########
@@ -67,6 +67,26 @@ def test_measure_local_builder_runner():
assert mress[0].error_no == 0
+def test_measure_local_builder_rpc_runner():
+ dag, s0 = get_tiled_matmul()
+
+ if not tvm.runtime.enabled("llvm"):
+ return
Review comment:
let's move these two lines to the beginning of this function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] merrymercy merged pull request #6077: [Ansor][AutoTVM v2.0] Phase 1: Add RPC Runner
Posted by GitBox <gi...@apache.org>.
merrymercy merged pull request #6077:
URL: https://github.com/apache/incubator-tvm/pull/6077
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] junrushao1994 commented on pull request #6077: [Ansor][AutoTVM v2.0] Part 1: Add RPC Runner
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #6077:
URL: https://github.com/apache/incubator-tvm/pull/6077#issuecomment-659624761
Thanks for the PR! Will take a look this weekend😄
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-tvm] jcf94 commented on pull request #6077: [Ansor][AutoTVM v2.0] Phase 1: Add RPC Runner
Posted by GitBox <gi...@apache.org>.
jcf94 commented on pull request #6077:
URL: https://github.com/apache/incubator-tvm/pull/6077#issuecomment-659778310
> @jcf94 Gental reminder: To reproduce Ansor paper's result, we should turn on clflush (for x86 cpu) and non empty array. clflush has been merged, you should consider to put it in this pr([clflush link](https://github.com/apache/incubator-tvm/pull/5914), non empty array pr I will do it as soon as possile. If that can not be merged before this pr, I could handle it after this pr is merged. Wish this info could make you aware we have some depentcy. Thanks.
Ok, actually this is the least important part of phase 1.
We can left this PR later, or I think it does seem better for you to fix the non empty & clflush parts after this PR. I'll add some TODO hints in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org